Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Action in notices are hard to... notice (ha-ha, get it?) #19926

Closed
klimeryk opened this issue Nov 16, 2017 · 5 comments
Closed

Components: Action in notices are hard to... notice (ha-ha, get it?) #19926

klimeryk opened this issue Nov 16, 2017 · 5 comments

Comments

@klimeryk
Copy link
Contributor

Is it just me or did the changes in #17796 actually decrease the contrast and readability of actions in notices?

Before:
screen shot 2017-11-16 at 17 24 05

After:
screen shot 2017-11-16 at 17 20 53

If I did not know better, I would not know that there are clickable actions in the new notices :/

The more subdued color of the action along with no change in the background for them makes all the less discoverable, it seems.

@klimeryk klimeryk added Components [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Nov 16, 2017
@shaunandrews
Copy link
Contributor

  • I find these new notices very masculine and "heavy," and (contradicting myself) they also seem to "fade away" into the rest of the screen.
  • I agree that the actions (which are usually pretty important) are less noticeable, and not easy to read.
  • I find the reversed light-on-dark text for the messaging hard to read as well — its almost as if the pure white text is "vibrating" on the dark background.

@stale
Copy link

stale bot commented Sep 8, 2018

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 8, 2018
@klimeryk
Copy link
Contributor Author

klimeryk commented Sep 9, 2018

@Automattic/design are there any plans to address/improve this or should this issue be closed?

@stale stale bot removed the [Status] Stale label Sep 9, 2018
@davewhitley
Copy link
Contributor

It can be closed. We are redesigning these notices in the next few months or so.

@klimeryk
Copy link
Contributor Author

Awesome, thanks for the update! 👍

@matticbot matticbot removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants