Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site settings: sync notification looks weird #20356

Closed
simison opened this issue Nov 30, 2017 · 2 comments
Closed

Site settings: sync notification looks weird #20356

simison opened this issue Nov 30, 2017 · 2 comments

Comments

@simison
Copy link
Member

simison commented Nov 30, 2017

Steps to reproduce

  1. Starting at URL: https://wordpress.com/settings/manage-connection/:site (jetpack site)
  2. Let "Data synchronization" section load
  3. See "Last fully synced" notification

What I expected

This is how notification looked before PR #17796 "Update notice colors to pass WCAG AA guidelines":

image

What happened instead

This is how it looks today:
image

Context / Source

Seems to boil down to the fact that there's some custom css modifying that sync notice.

See how Notices normally look like (choose "Compact Notices").

Checking out an issue about inline notice styles might be relevant.

/cc @jameskoster

@simison
Copy link
Member Author

simison commented Nov 30, 2017

I could send a quick PR to fix this.

Would regular just <p></p> suffice? Notice element doesn't seem to have any ARIA attributes that we'd be missing (tho it might have them in future).

If design change would be okay, a quick fix would be make it look like either one of these:

image

...or even like <FormSettingExplanation>:
image

@designsimply designsimply added the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Nov 30, 2017
@davewhitley
Copy link
Contributor

davewhitley commented Nov 30, 2017

In my opinion, it probably shouldn't be a Notice. I haven't viewed the whole context of the page, but your suggestion to just use gray text seems good to me.

@simison simison self-assigned this Nov 30, 2017
@matticbot matticbot removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants