-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar: fix to restore upsell ads old styling (Free Domain, Upgrade) #20833
Conversation
Thank you for this! Just a tiny note for testing that the site needs to be 2-180 days old for the free-to-paid - the nudge isn't currently shown on D1 sites. |
The nudge is not showing for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When they are other notices, doesn't look consistent.
Agreed, we should make sure all of these are consistent. |
There's a longer discussion about why these notices should be different than the others on marketingscratchpad - pinging @apeatling and @aidvu with the link for background. Edited to add the p2 link - [code p2-p7EOS0-442] |
Both are done on purpose (the letter aligns with the end of the color, if it would align with text it would look off for too much space). They match the old design. This PR is meant to be a quick fix. Let's get this in, then we have time to create a new component ad hoc that isn't a hack and adjust all the above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in and iterate. Chances someone sees more than 1-2 notices are very low.
Thank you 🌟 |
This PR restores the styling of the upgrade banners in the sidebar that were changed as a side effect of #17796.
Before:
After:
Note: in the screenshot I forced both the banners to be visible, they aren't normally.
The fix isn't amazing, it's just adding a class and overriding the styling. This needs later to me moved to an ad-hoc component for marketing purposes.
To review