Security: update notice styles in backup section #23487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Refactor header to use `Notice` component instead of custom styles: - Improves accessibility by following WCAG AA guidelines for contrast ratio. - Matches with other Calypso notifications, updated in #17796 2) Use `SectionHeader` component for positioning elements
simison
added
[Feature] Site Settings
|
I love this. Nice work. Ship it! |
MichaelArestad
added
[Status] Ready to Merge
and removed
[Status] Needs Review
MichaelArestad
approved these changes
Mar 21, 2018
simison
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Noticecomponent instead of custom styles to match with other Calypso notifications, updated in Update notice colors to pass WCAG AA guidelines #17796Use
SectionHeadercomponent for the header instead ofCompactCard(works better for alignment)There's a similar PR in Jetpack open: Automattic/jetpack#9080
The section below the header has some style issues in mobile; I'll address those in a separate PR.
Screenshots (before & after)
Mobile
Desktop
Testing
https://wordpress.com/settings/security/:siteand see that the section works and looks good in different screen sizes.