Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin packages (Part 5) #42142

Merged
merged 1 commit into from
May 15, 2020
Merged

Unpin packages (Part 5) #42142

merged 1 commit into from
May 15, 2020

Conversation

scinos
Copy link
Contributor

@scinos scinos commented May 13, 2020

Changes proposed in this Pull Request

  • Unpin all dependencies in client/package.json (

Changes in the dependency tree:

< Before
> After
---
< wp-calypso-monorepo@0.17.0 wp-calypso@0.17.0 events@3.0.0
---
> wp-calypso-monorepo@0.17.0 wp-calypso@0.17.0 events@3.1.0
3063614c3063614
< wp-calypso-monorepo@0.17.0 wp-calypso@0.17.0 fast-json-stable-stringify@2.0.0
---
> wp-calypso-monorepo@0.17.0 wp-calypso@0.17.0 fast-json-stable-stringify@2.1.0

Changelogs from the affected packages:

Testing instructions

  • Verify all tests pass
  • Verify there are no new packages introduced (other than the two specified above): run find . -type d -name node_modules | xargs rm -fr && yarn && NODE_OPTIONS=--max_old_space_size=8192 yarn run effective-module-tree -o list in this branch and master (tested with commit f633e90), save the output to a file and diff them.

@scinos scinos requested review from a team as code owners May 13, 2020 08:25
@matticbot
Copy link
Contributor

@scinos scinos self-assigned this May 13, 2020
@scinos scinos added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 13, 2020
@scinos
Copy link
Contributor Author

scinos commented May 13, 2020

After this PR will only have unpinned dependencies in ./package.json, in @wordpress/* packages but that is blocked by #41994

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~6050 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-gutenboarding        -5755 B  (-0.3%)    -1502 B  (-0.3%)
entry-domains-landing      -5755 B  (-1.0%)    -1521 B  (-1.0%)
entry-main                 -5752 B  (-0.4%)    -1512 B  (-0.4%)
entry-login                -5752 B  (-0.7%)    -1515 B  (-0.6%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@simison
Copy link
Member

simison commented May 15, 2020

in @wordpress/* packages but that is blocked by #41994

That got closed, follow up in #42031

Copy link
Contributor

@griffbrad griffbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Tests well for me. Thanks!

@scinos scinos merged commit 6c4cf9f into master May 15, 2020
@scinos scinos deleted the update/unpin-dependencies-5 branch May 15, 2020 11:57
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2020
@scinos scinos mentioned this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants