-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Site Editor close button for G v11.9 #57909
Fix Site Editor close button for G v11.9 #57909
Conversation
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:commit-b24804132fdf4a0ad726046a65d1e45885527d22 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Curious about this:
Does that mean there's a fix for this in core that was introduced and scheduled for v12.0? |
@fullofcaffeine yes, see WordPress/gutenberg#36369 |
It looks like that fix is being cherry picked into 11.9. We may need to update things as we are currently filling that slot for its previous context of being inside the nav sidebar and wrapping the |
Changes proposed in this Pull Request
With Gutenberg v11.9, the navigation toggle was removed. This caused our override to close the editor to no longer work, thus the editor in 11.9 now tries to close to wp-admin instead of calypso, which is not allowed and results in this gray screen:
Here, we add the selector for the new close button to keep the same override functionality. Once v12.0 is shipped to dotcom, we can get rid of this hacky goo altogether and go back to using the slot/fill for overriding the close button.
Testing instructions
Related to #