-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move adminInterface
check to shouldShowGlobalSiteSidebar
#87583
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~768 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~96 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Merging this PR, as I need to use this selector in https://github.com/Automattic/dotcom-forge/issues/5628. Feel free to change it afterward. |
Related to https://github.com/Automattic/dotcom-forge/issues/5609
Proposed Changes
This pull request refactors the location of the
adminInterface
check, moving it into theshouldShowGlobalSiteSidebar
function.This change aims to streamline code by reducing the number of code seams. Previously implemented as a hook, the
adminInterface
check has been transformed into a selector, so it can now be utilized within both functional and connected components.Testing Instructions
Pre-merge Checklist