From b8f127fce7807064d453ff7245ef481adba493fb Mon Sep 17 00:00:00 2001
From: Steven Kirk <grokys@users.noreply.github.com>
Date: Mon, 25 Jun 2018 00:06:40 +0200
Subject: [PATCH 1/4] Reimplemented TemplateBinding.

Rather than just use a standard `Binding`, make `TemplateBinding` a lightweight binding in the case where the binding is simply to a property on the templated parent.
---
 samples/ControlCatalog/SideBar.xaml           |   4 +-
 samples/RenderDemo/SideBar.xaml               |   4 +-
 .../AutoCompleteBox.xaml                      |   2 +-
 src/Avalonia.Themes.Default/DropDown.xaml     |   2 +-
 src/Avalonia.Themes.Default/MenuItem.xaml     |   4 +-
 src/Avalonia.Themes.Default/ScrollBar.xaml    |   4 +-
 src/Avalonia.Themes.Default/ScrollViewer.xaml |  10 +-
 src/Avalonia.Themes.Default/Slider.xaml       |   7 +-
 src/Avalonia.Themes.Default/TabControl.xaml   |   4 +-
 src/Avalonia.Themes.Default/TextBox.xaml      |   2 +-
 src/Avalonia.Themes.Default/TreeViewItem.xaml |   4 +-
 .../AvaloniaXamlLoader.cs                     |   2 +-
 .../AvaloniaPropertyTypeConverter.cs          |  89 +++++----
 .../TemplateBindingExtension.cs               |  42 +++--
 .../PortableXaml/AvaloniaXamlSchemaContext.cs |   1 +
 .../PortableXaml/TypeDescriptorExtensions.cs  |   8 +-
 .../Templates/ControlTemplate.cs              |   6 +-
 .../Avalonia.Markup/Data/TemplateBinding.cs   | 169 ++++++++++++++++++
 .../AvaloniaPropertyConverterTest.cs          |  13 +-
 .../Data/BindingTests_TemplatedParent.cs      |  14 +-
 .../Xaml/BasicTests.cs                        |   2 +-
 21 files changed, 285 insertions(+), 108 deletions(-)
 create mode 100644 src/Markup/Avalonia.Markup/Data/TemplateBinding.cs

diff --git a/samples/ControlCatalog/SideBar.xaml b/samples/ControlCatalog/SideBar.xaml
index e5baf9e942c..7d72d1821bd 100644
--- a/samples/ControlCatalog/SideBar.xaml
+++ b/samples/ControlCatalog/SideBar.xaml
@@ -8,7 +8,7 @@
             <TabStrip Name="PART_TabStrip"
                       MemberSelector="{x:Static TabControl.HeaderSelector}"
                       Items="{TemplateBinding Items}"
-                      SelectedIndex="{TemplateBinding Path=SelectedIndex, Mode=TwoWay}">
+                      SelectedIndex="{TemplateBinding SelectedIndex, Mode=TwoWay}">
               <TabStrip.ItemsPanel>
                 <ItemsPanelTemplate>
                   <StackPanel Orientation="Vertical"/>
@@ -20,7 +20,7 @@
                     Margin="8 0 0 0"
                     MemberSelector="{x:Static TabControl.ContentSelector}"
                     Items="{TemplateBinding Items}"
-                    SelectedIndex="{TemplateBinding Path=SelectedIndex}"
+                    SelectedIndex="{TemplateBinding SelectedIndex}"
                     PageTransition="{TemplateBinding PageTransition}"
                     Grid.Row="1"/>
         </DockPanel>
diff --git a/samples/RenderDemo/SideBar.xaml b/samples/RenderDemo/SideBar.xaml
index 29e5d854f94..b5f8ccaf017 100644
--- a/samples/RenderDemo/SideBar.xaml
+++ b/samples/RenderDemo/SideBar.xaml
@@ -9,7 +9,7 @@
             <TabStrip Name="PART_TabStrip"
                       MemberSelector="{x:Static TabControl.HeaderSelector}"
                       Items="{TemplateBinding Items}"
-                      SelectedIndex="{TemplateBinding Path=SelectedIndex, Mode=TwoWay}">
+                      SelectedIndex="{TemplateBinding SelectedIndex, Mode=TwoWay}">
               <TabStrip.ItemsPanel>
                 <ItemsPanelTemplate>
                   <StackPanel Orientation="Vertical"/>
@@ -21,7 +21,7 @@
                     Margin="8 0 0 0"
                     MemberSelector="{x:Static TabControl.ContentSelector}"
                     Items="{TemplateBinding Items}"
-                    SelectedIndex="{TemplateBinding Path=SelectedIndex}"
+                    SelectedIndex="{TemplateBinding SelectedIndex}"
                     PageTransition="{TemplateBinding PageTransition}"
                     Grid.Row="1"/>
         </DockPanel>
diff --git a/src/Avalonia.Themes.Default/AutoCompleteBox.xaml b/src/Avalonia.Themes.Default/AutoCompleteBox.xaml
index 82dbf6064bd..6a9af487cba 100644
--- a/src/Avalonia.Themes.Default/AutoCompleteBox.xaml
+++ b/src/Avalonia.Themes.Default/AutoCompleteBox.xaml
@@ -16,7 +16,7 @@
                    DataValidationErrors.Errors="{TemplateBinding (DataValidationErrors.Errors)}" />
           
           <Popup Name="PART_Popup"
-                 MinWidth="{TemplateBinding Bounds.Width}"
+                 MinWidth="{Binding Bounds.Width, RelativeSource={RelativeSource TemplatedParent}}"
                  MaxHeight="{TemplateBinding MaxDropDownHeight}"
                  PlacementTarget="{TemplateBinding}"
                  StaysOpen="False">
diff --git a/src/Avalonia.Themes.Default/DropDown.xaml b/src/Avalonia.Themes.Default/DropDown.xaml
index 139b2b3687d..c57d961f4ba 100644
--- a/src/Avalonia.Themes.Default/DropDown.xaml
+++ b/src/Avalonia.Themes.Default/DropDown.xaml
@@ -32,7 +32,7 @@
             </ToggleButton>
             <Popup Name="PART_Popup"
                    IsOpen="{TemplateBinding IsDropDownOpen, Mode=TwoWay}"
-                   MinWidth="{TemplateBinding Bounds.Width}"
+                   MinWidth="{Binding Bounds.Width, RelativeSource={RelativeSource TemplatedParent}}"
                    MaxHeight="{TemplateBinding MaxDropDownHeight}"
                    PlacementTarget="{TemplateBinding}"
                    StaysOpen="False">
diff --git a/src/Avalonia.Themes.Default/MenuItem.xaml b/src/Avalonia.Themes.Default/MenuItem.xaml
index efb31175fa2..53965db016a 100644
--- a/src/Avalonia.Themes.Default/MenuItem.xaml
+++ b/src/Avalonia.Themes.Default/MenuItem.xaml
@@ -45,7 +45,7 @@
             <Popup Name="PART_Popup"
                    PlacementMode="Right"
                    StaysOpen="True"
-                   IsOpen="{TemplateBinding Path=IsSubMenuOpen, Mode=TwoWay}"
+                   IsOpen="{TemplateBinding IsSubMenuOpen, Mode=TwoWay}"
                    ObeyScreenEdges="True">
               <Border Background="{TemplateBinding Background}"
                       BorderBrush="{DynamicResource ThemeBorderMidBrush}"
@@ -92,7 +92,7 @@
               </ContentPresenter.DataTemplates>
             </ContentPresenter>
             <Popup Name="PART_Popup"
-                   IsOpen="{TemplateBinding Path=IsSubMenuOpen, Mode=TwoWay}"
+                   IsOpen="{TemplateBinding IsSubMenuOpen, Mode=TwoWay}"
                    StaysOpen="True" 
                    ObeyScreenEdges="True">
               <Border Background="{TemplateBinding Background}"
diff --git a/src/Avalonia.Themes.Default/ScrollBar.xaml b/src/Avalonia.Themes.Default/ScrollBar.xaml
index d2703841231..b24c863be9e 100644
--- a/src/Avalonia.Themes.Default/ScrollBar.xaml
+++ b/src/Avalonia.Themes.Default/ScrollBar.xaml
@@ -16,7 +16,7 @@
                                Grid.Column="1"
                                Minimum="{TemplateBinding Minimum}"
                                Maximum="{TemplateBinding Maximum}"
-                               Value="{TemplateBinding Path=Value, Mode=TwoWay}"
+                               Value="{TemplateBinding Value, Mode=TwoWay}"
                                ViewportSize="{TemplateBinding ViewportSize}"
                                Orientation="{TemplateBinding Orientation}">
                             <Track.DecreaseButton>
@@ -67,7 +67,7 @@
                                Grid.Column="1"
                                Minimum="{TemplateBinding Minimum}"
                                Maximum="{TemplateBinding Maximum}"
-                               Value="{TemplateBinding Path=Value, Mode=TwoWay}"
+                               Value="{TemplateBinding Value, Mode=TwoWay}"
                                ViewportSize="{TemplateBinding ViewportSize}"
                                Orientation="{TemplateBinding Orientation}">
                             <Track.DecreaseButton>
diff --git a/src/Avalonia.Themes.Default/ScrollViewer.xaml b/src/Avalonia.Themes.Default/ScrollViewer.xaml
index 5355d5c7c30..c493fb32e3f 100644
--- a/src/Avalonia.Themes.Default/ScrollViewer.xaml
+++ b/src/Avalonia.Themes.Default/ScrollViewer.xaml
@@ -9,21 +9,21 @@
                                 CanHorizontallyScroll="{TemplateBinding CanHorizontallyScroll}"
                                 CanVerticallyScroll="{TemplateBinding CanVerticallyScroll}"
                                 Content="{TemplateBinding Content}"
-                                Extent="{TemplateBinding Path=Extent, Mode=TwoWay}"
+                                Extent="{TemplateBinding Extent, Mode=TwoWay}"
                                 Margin="{TemplateBinding Padding}"
-                                Offset="{TemplateBinding Path=Offset, Mode=TwoWay}"
-                                Viewport="{TemplateBinding Path=Viewport, Mode=TwoWay}"/>
+                                Offset="{TemplateBinding Offset, Mode=TwoWay}"
+                                Viewport="{TemplateBinding Viewport, Mode=TwoWay}"/>
         <ScrollBar Name="horizontalScrollBar"
                    Orientation="Horizontal"
                    Maximum="{TemplateBinding HorizontalScrollBarMaximum}"
-                   Value="{TemplateBinding Path=HorizontalScrollBarValue, Mode=TwoWay}"
+                   Value="{TemplateBinding HorizontalScrollBarValue, Mode=TwoWay}"
                    ViewportSize="{TemplateBinding HorizontalScrollBarViewportSize}"
                    Visibility="{TemplateBinding HorizontalScrollBarVisibility}"
                    Grid.Row="1"/>
         <ScrollBar Name="verticalScrollBar"
                    Orientation="Vertical"
                    Maximum="{TemplateBinding VerticalScrollBarMaximum}"
-                   Value="{TemplateBinding Path=VerticalScrollBarValue, Mode=TwoWay}"
+                   Value="{TemplateBinding VerticalScrollBarValue, Mode=TwoWay}"
                    ViewportSize="{TemplateBinding VerticalScrollBarViewportSize}"
                    Visibility="{TemplateBinding VerticalScrollBarVisibility}"
                    Grid.Column="1"/>
diff --git a/src/Avalonia.Themes.Default/Slider.xaml b/src/Avalonia.Themes.Default/Slider.xaml
index 09446124171..58fd67b2f65 100644
--- a/src/Avalonia.Themes.Default/Slider.xaml
+++ b/src/Avalonia.Themes.Default/Slider.xaml
@@ -11,7 +11,7 @@
             <RowDefinition Height="Auto"/>
           </Grid.RowDefinitions>
           <Border Name="TrackBackground" Grid.Row="1" Height="4" Margin="6,0" VerticalAlignment="Center"/>
-          <Track Name="PART_Track" Grid.Row="1">
+          <Track Name="PART_Track" Grid.Row="1" Orientation="Horizontal">
             <Track.DecreaseButton>
                <RepeatButton Name="PART_DecreaseButton"
                              Classes="repeattrack" />
@@ -46,7 +46,7 @@
             <ColumnDefinition Width="Auto"/>
           </Grid.ColumnDefinitions>
           <Border Name="TrackBackground" Grid.Column="1" Width="4" Margin="0,6" HorizontalAlignment="Center"/>
-          <Track Name="PART_Track" Grid.Column="1">
+          <Track Name="PART_Track" Grid.Column="1" Orientation="Vertical">
             <Track.DecreaseButton>
                <RepeatButton Name="PART_DecreaseButton"
                              Classes="repeattrack" />
@@ -72,8 +72,7 @@
   <Style Selector="Slider /template/ Track#PART_Track">
     <Setter Property="Minimum" Value="{TemplateBinding Minimum}"/>
     <Setter Property="Maximum" Value="{TemplateBinding Maximum}"/>
-    <Setter Property="Value" Value="{TemplateBinding Path=Value, Mode=TwoWay}"/>
-    <Setter Property="Orientation" Value="{TemplateBinding Orientation}"/>
+    <Setter Property="Value" Value="{TemplateBinding Value, Mode=TwoWay}"/>
   </Style>
   <Style Selector="Slider /template/ Border#TrackBackground">
     <Setter Property="BorderThickness" Value="2"/>
diff --git a/src/Avalonia.Themes.Default/TabControl.xaml b/src/Avalonia.Themes.Default/TabControl.xaml
index 0196c1f3ab2..76cf1901517 100644
--- a/src/Avalonia.Themes.Default/TabControl.xaml
+++ b/src/Avalonia.Themes.Default/TabControl.xaml
@@ -9,11 +9,11 @@
             <TabStrip Name="PART_TabStrip"
                       MemberSelector="{x:Static TabControl.HeaderSelector}"
                       Items="{TemplateBinding Items}"
-                      SelectedIndex="{TemplateBinding Path=SelectedIndex, Mode=TwoWay}"/>
+                      SelectedIndex="{TemplateBinding SelectedIndex, Mode=TwoWay}"/>
             <Carousel Name="PART_Content"
                       MemberSelector="{x:Static TabControl.ContentSelector}"
                       Items="{TemplateBinding Items}"
-                      SelectedIndex="{TemplateBinding Path=SelectedIndex}"
+                      SelectedIndex="{TemplateBinding SelectedIndex}"
                       PageTransition="{TemplateBinding PageTransition}"
                       Grid.Row="1"/>
           </DockPanel>
diff --git a/src/Avalonia.Themes.Default/TextBox.xaml b/src/Avalonia.Themes.Default/TextBox.xaml
index c57e5b792d3..44beb33232f 100644
--- a/src/Avalonia.Themes.Default/TextBox.xaml
+++ b/src/Avalonia.Themes.Default/TextBox.xaml
@@ -36,7 +36,7 @@
                   <TextBlock Name="watermark"
                              Opacity="0.5"
                              Text="{TemplateBinding Watermark}"
-                             IsVisible="{TemplateBinding Path=Text, Converter={x:Static StringConverters.NullOrEmpty}}"/>
+                             IsVisible="{TemplateBinding Text, Converter={x:Static StringConverters.NullOrEmpty}}"/>
                   <TextPresenter Name="PART_TextPresenter"
                                  Text="{TemplateBinding Text, Mode=TwoWay}"
                                  CaretIndex="{TemplateBinding CaretIndex}"
diff --git a/src/Avalonia.Themes.Default/TreeViewItem.xaml b/src/Avalonia.Themes.Default/TreeViewItem.xaml
index 3a8fe344c5e..95347044bc8 100644
--- a/src/Avalonia.Themes.Default/TreeViewItem.xaml
+++ b/src/Avalonia.Themes.Default/TreeViewItem.xaml
@@ -7,14 +7,12 @@
           <Grid ColumnDefinitions="16, Auto">
             <ToggleButton Name="expander"
                           Focusable="False"
-                          IsChecked="{TemplateBinding Path=IsExpanded, Mode=TwoWay}"/>
+                          IsChecked="{TemplateBinding IsExpanded, Mode=TwoWay}"/>
             <ContentPresenter Name="PART_HeaderPresenter"
                               Background="{TemplateBinding Background}"
                               BorderBrush="{TemplateBinding BorderBrush}"
                               BorderThickness="{TemplateBinding BorderThickness}"
                               Content="{TemplateBinding Header}"
-                              HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
-                              VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}"
                               Padding="{TemplateBinding Padding}"
                               TemplatedControl.IsTemplateFocusTarget="True"
                               Grid.Column="1"/>
diff --git a/src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs b/src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs
index c3613728201..473b97b51a9 100644
--- a/src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs
+++ b/src/Markup/Avalonia.Markup.Xaml/AvaloniaXamlLoader.cs
@@ -139,7 +139,7 @@ public object Load(Uri uri, Uri baseUri = null, object rootInstance = null)
                     {
                         uriString = new Uri(baseUri, uri).AbsoluteUri;
                     }
-                    throw new XamlLoadException("Error loading xaml at " + uriString, e);
+                    throw new XamlLoadException("Error loading xaml at " + uriString + ": " + e.Message, e);
                 }
             }
         }
diff --git a/src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs b/src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs
index 131cb5a20b8..1fd73d5061e 100644
--- a/src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs
+++ b/src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs
@@ -2,19 +2,21 @@
 // Licensed under the MIT license. See licence.md file in the project root for full license information.
 
 using System;
+using System.ComponentModel;
 using System.Globalization;
-using System.Linq;
+using System.Text.RegularExpressions;
+using Avalonia.Markup.Xaml.Templates;
+using Avalonia.Styling;
+using Portable.Xaml;
+using Portable.Xaml.ComponentModel;
+using Portable.Xaml.Markup;
 
 namespace Avalonia.Markup.Xaml.Converters
 {
-    using Avalonia.Styling;
-    using Portable.Xaml;
-    using Portable.Xaml.ComponentModel;
-    using System.ComponentModel;
-    using Portable.Xaml.Markup;
-
     public class AvaloniaPropertyTypeConverter : TypeConverter
     {
+        private static readonly Regex regex = new Regex(@"^\(?(\w*)\.(\w*)\)?|(.*)$");
+
         public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)
         {
             return sourceType == typeof(string);
@@ -22,65 +24,62 @@ public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceT
 
         public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
         {
-            var s = (string)value;
-
-            string typeName;
-            string propertyName;
-            Type type = null;
+            var (owner, propertyName) = ParseProperty((string)value);
+            var ownerType = TryResolveOwnerByName(context, owner) ??
+                context.GetFirstAmbientValue<ControlTemplate>()?.TargetType ??
+                context.GetFirstAmbientValue<Style>()?.Selector?.TargetType;
 
-            ParseProperty(s, out typeName, out propertyName);
+            var ipvt = context.GetService<IProvideValueTarget>();
+            var idtp = context.GetService<IDestinationTypeProvider>();
+            var ao = context.GetFirstAmbientValue<AvaloniaObject>();
 
-            if (typeName == null)
+            if (ownerType == null)
             {
-                var style = context.GetFirstAmbientValue<Style>();
+                throw new XamlLoadException(
+                    $"Could not determine the owner type for property '{propertyName}'. " +
+                    "Please fully qualify the property name or specify a target type on " +
+                    "the containing template.");
+            }
 
-                type = style?.Selector?.TargetType;
+            var property = AvaloniaPropertyRegistry.Instance.FindRegistered(ownerType, propertyName);
 
-                if (type == null)
-                {
-                    throw new Exception(
-                        "Could not determine the target type. Please fully qualify the property name.");
-                }
+            if (property == null)
+            {
+                throw new XamlLoadException($"Could not find AvaloniaProperty '{ownerType.Name}.{propertyName}'.");
             }
-            else
+
+            return property;
+        }
+
+        private Type TryResolveOwnerByName(ITypeDescriptorContext context, string owner)
+        {
+            if (owner != null)
             {
-                var typeResolver = context.GetService<IXamlTypeResolver>();
-                type = typeResolver.Resolve(typeName);
+                var resolver = context.GetService<IXamlTypeResolver>();
+                var result = resolver.Resolve(owner);
 
-                if (type == null)
+                if (result == null)
                 {
-                    throw new Exception($"Could not find type '{typeName}'.");
+                    throw new XamlLoadException($"Could not find type '{owner}'.");
                 }
-            }
-
-            AvaloniaProperty property = AvaloniaPropertyRegistry.Instance.FindRegistered(type, propertyName);
 
-            if (property == null)
-            {
-                throw new Exception(
-                    $"Could not find AvaloniaProperty '{type.Name}.{propertyName}'.");
+                return result;
             }
 
-            return property;
+            return null;
         }
 
-        private void ParseProperty(string s, out string typeName, out string propertyName)
+        private (string owner, string property) ParseProperty(string s)
         {
-            var split = s.Split('.');
+            var result = regex.Match(s);
 
-            if (split.Length == 1)
-            {
-                typeName = null;
-                propertyName = split[0];
-            }
-            else if (split.Length == 2)
+            if (result.Groups[1].Success)
             {
-                typeName = split[0];
-                propertyName = split[1];
+                return (result.Groups[1].Value, result.Groups[2].Value);
             }
             else
             {
-                throw new Exception($"Invalid property name: '{s}'.");
+                return (null, result.Groups[3].Value);
             }
         }
     }
diff --git a/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TemplateBindingExtension.cs b/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TemplateBindingExtension.cs
index c8fc8a41d1f..60b2b735584 100644
--- a/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TemplateBindingExtension.cs
+++ b/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TemplateBindingExtension.cs
@@ -1,15 +1,13 @@
 // Copyright (c) The Avalonia Project. All rights reserved.
 // Licensed under the MIT license. See licence.md file in the project root for full license information.
 
+using System;
 using Avalonia.Data;
+using Avalonia.Data.Converters;
+using Portable.Xaml.Markup;
 
 namespace Avalonia.Markup.Xaml.MarkupExtensions
 {
-    using System;
-    using Avalonia.Data.Converters;
-    using Avalonia.Markup.Data;
-    using Portable.Xaml.Markup;
-
     [MarkupExtensionReturnType(typeof(IBinding))]
     public class TemplateBindingExtension : MarkupExtension
     {
@@ -17,35 +15,41 @@ public TemplateBindingExtension()
         {
         }
 
-        public TemplateBindingExtension(string path)
+        public TemplateBindingExtension(AvaloniaProperty property)
         {
-            Path = path;
+            Property = property;
         }
 
         public override object ProvideValue(IServiceProvider serviceProvider)
         {
-            return new Binding
+            return new TemplateBinding
             {
                 Converter = Converter,
-                ElementName = ElementName,
+                ConverterParameter = ConverterParameter,
                 Mode = Mode,
-                RelativeSource = new RelativeSource(RelativeSourceMode.TemplatedParent),
-                Path = Path ?? string.Empty,
-                Priority = Priority,
+                Property = Property,
             };
         }
 
+        /// <summary>
+        /// Gets or sets the <see cref="IValueConverter"/> to use.
+        /// </summary>
         public IValueConverter Converter { get; set; }
 
-        public string ElementName { get; set; }
-
-        public object FallbackValue { get; set; }
+        /// <summary>
+        /// Gets or sets a parameter to pass to <see cref="Converter"/>.
+        /// </summary>
+        public object ConverterParameter { get; set; }
 
+        /// <summary>
+        /// Gets or sets the binding mode.
+        /// </summary>
         public BindingMode Mode { get; set; }
 
-        [ConstructorArgument("path")]
-        public string Path { get; set; }
-
-        public BindingPriority Priority { get; set; } = BindingPriority.TemplatedParent;
+        /// <summary>
+        /// Gets or sets the name of the source property on the templated parent.
+        /// </summary>
+        [ConstructorArgument("property")]
+        public AvaloniaProperty Property { get; set; }
     }
 }
\ No newline at end of file
diff --git a/src/Markup/Avalonia.Markup.Xaml/PortableXaml/AvaloniaXamlSchemaContext.cs b/src/Markup/Avalonia.Markup.Xaml/PortableXaml/AvaloniaXamlSchemaContext.cs
index 70402aa7648..7de3fcf46a0 100644
--- a/src/Markup/Avalonia.Markup.Xaml/PortableXaml/AvaloniaXamlSchemaContext.cs
+++ b/src/Markup/Avalonia.Markup.Xaml/PortableXaml/AvaloniaXamlSchemaContext.cs
@@ -166,6 +166,7 @@ public override XamlType GetXamlType(Type type)
         {
             { typeof(Binding), typeof(BindingExtension) },
             { typeof(StyleInclude), typeof(StyleIncludeExtension) },
+            { typeof(TemplateBinding), typeof(TemplateBindingExtension) },
         };
 
         private XamlType GetAvaloniaXamlType(Type type)
diff --git a/src/Markup/Avalonia.Markup.Xaml/PortableXaml/TypeDescriptorExtensions.cs b/src/Markup/Avalonia.Markup.Xaml/PortableXaml/TypeDescriptorExtensions.cs
index 458b09b66e8..9eb88b603ca 100644
--- a/src/Markup/Avalonia.Markup.Xaml/PortableXaml/TypeDescriptorExtensions.cs
+++ b/src/Markup/Avalonia.Markup.Xaml/PortableXaml/TypeDescriptorExtensions.cs
@@ -44,15 +44,17 @@ public static T GetFirstAmbientValue<T>(this ITypeDescriptorContext ctx) where T
             var amb = ctx.GetService<IAmbientProvider>();
             var sc = ctx.GetService<IXamlSchemaContextProvider>().SchemaContext;
 
-            return amb.GetFirstAmbientValue(sc.GetXamlType(typeof(T))) as T;
+            // Because GetFirstAmbientValue uses XamlType.CanAssignTo it returns values that
+            // aren't actually of the correct type. Use GetAllAmbientValues instead.
+            return amb.GetAllAmbientValues(sc.GetXamlType(typeof(T))).OfType<T>().FirstOrDefault();
         }
 
         public static T GetLastOrDefaultAmbientValue<T>(this ITypeDescriptorContext ctx) where T : class
         {
-            return ctx.GetAllambientValues<T>().LastOrDefault() as T;
+            return ctx.GetAllAmbientValues<T>().LastOrDefault() as T;
         }
 
-        public static IEnumerable<T> GetAllambientValues<T>(this ITypeDescriptorContext ctx) where T : class
+        public static IEnumerable<T> GetAllAmbientValues<T>(this ITypeDescriptorContext ctx) where T : class
         {
             var amb = ctx.GetService<IAmbientProvider>();
             var sc = ctx.GetService<IXamlSchemaContextProvider>().SchemaContext;
diff --git a/src/Markup/Avalonia.Markup.Xaml/Templates/ControlTemplate.cs b/src/Markup/Avalonia.Markup.Xaml/Templates/ControlTemplate.cs
index f010425be5d..e28828625f1 100644
--- a/src/Markup/Avalonia.Markup.Xaml/Templates/ControlTemplate.cs
+++ b/src/Markup/Avalonia.Markup.Xaml/Templates/ControlTemplate.cs
@@ -1,6 +1,7 @@
 // Copyright (c) The Avalonia Project. All rights reserved.
 // Licensed under the MIT license. See licence.md file in the project root for full license information.
 
+using System;
 using Avalonia.Controls;
 using Avalonia.Controls.Templates;
 using Avalonia.Metadata;
@@ -14,7 +15,8 @@ public class ControlTemplate : IControlTemplate
         [TemplateContent]
         public object Content { get; set; }
 
-        public IControl Build(ITemplatedControl control)
-                            => TemplateContent.Load(Content);
+        public Type TargetType { get; set; }
+
+        public IControl Build(ITemplatedControl control) => TemplateContent.Load(Content);
     }
 }
\ No newline at end of file
diff --git a/src/Markup/Avalonia.Markup/Data/TemplateBinding.cs b/src/Markup/Avalonia.Markup/Data/TemplateBinding.cs
new file mode 100644
index 00000000000..8402d882361
--- /dev/null
+++ b/src/Markup/Avalonia.Markup/Data/TemplateBinding.cs
@@ -0,0 +1,169 @@
+using System;
+using System.Globalization;
+using System.Reactive.Subjects;
+using Avalonia.Data.Converters;
+using Avalonia.Reactive;
+
+namespace Avalonia.Data
+{
+    /// <summary>
+    /// A XAML binding to a property on a control's templated parent.
+    /// </summary>
+    public class TemplateBinding : SingleSubscriberObservableBase<object>,
+        IBinding,
+        IDescription,
+        ISubject<object>
+    {
+        private IStyledElement _target;
+        private Type _targetType;
+
+        /// <inheritdoc/>
+        public InstancedBinding Initiate(
+            IAvaloniaObject target,
+            AvaloniaProperty targetProperty,
+            object anchor = null,
+            bool enableDataValidation = false)
+        {
+            // Usually each `TemplateBinding` will only be instantiated once; in this case we can
+            // use the `TemplateBinding` object itself as the instanced binding in order to save
+            // allocating a new object. If the binding *is* instantiated more than once (which can
+            // happen if it appears in a `Setter` for example, then just make a clone and instantiate
+            // that.
+            if (_target == null)
+            {
+                _target = (IStyledElement)target;
+                _targetType = targetProperty?.PropertyType;
+
+                return new InstancedBinding(
+                    this,
+                    Mode == BindingMode.Default ? BindingMode.OneWay : Mode,
+                    BindingPriority.TemplatedParent);
+            }
+            else
+            {
+                var clone = new TemplateBinding
+                {
+                    Converter = Converter,
+                    ConverterParameter = ConverterParameter,
+                    Property = Property,
+                };
+
+                return clone.Initiate(target, targetProperty, anchor, enableDataValidation);
+            }
+        }
+
+        /// <summary>
+        /// Gets or sets the <see cref="IValueConverter"/> to use.
+        /// </summary>
+        public IValueConverter Converter { get; set; }
+
+        /// <summary>
+        /// Gets or sets a parameter to pass to <see cref="Converter"/>.
+        /// </summary>
+        public object ConverterParameter { get; set; }
+
+        /// <summary>
+        /// Gets or sets the binding mode.
+        /// </summary>
+        public BindingMode Mode { get; set; }
+
+        /// <summary>
+        /// Gets or sets the name of the source property on the templated parent.
+        /// </summary>
+        public AvaloniaProperty Property { get; set; }
+
+        /// <inheritdoc/>
+        public string Description => "TemplateBinding: " + Property;
+
+        void IObserver<object>.OnCompleted() => throw new NotImplementedException();
+        void IObserver<object>.OnError(Exception error) => throw new NotImplementedException();
+
+        void IObserver<object>.OnNext(object value)
+        {
+            if (_target.TemplatedParent != null && Property != null)
+            {
+                if (Converter != null)
+                {
+                    value = Converter.ConvertBack(
+                        value,
+                        Property.PropertyType,
+                        ConverterParameter,
+                        CultureInfo.CurrentCulture);
+                }
+
+                _target.TemplatedParent.SetValue(Property, value, BindingPriority.TemplatedParent);
+            }
+        }
+
+        protected override void Subscribed()
+        {
+            TemplatedParentChanged();
+            _target.PropertyChanged += TargetPropertyChanged;
+        }
+
+        protected override void Unsubscribed()
+        {
+            if (_target.TemplatedParent != null)
+            {
+                _target.TemplatedParent.PropertyChanged -= TemplatedParentPropertyChanged;
+            }
+
+            _target.PropertyChanged -= TargetPropertyChanged;
+        }
+
+        private void PublishValue()
+        {
+            if (_target.TemplatedParent != null)
+            {
+                var value = Property != null ?
+                    _target.TemplatedParent.GetValue(Property) :
+                    _target.TemplatedParent;
+
+                if (Converter != null)
+                {
+                    value = Converter.Convert(value, _targetType, ConverterParameter, CultureInfo.CurrentCulture);
+                }
+
+                PublishNext(value);
+            }
+            else
+            {
+                PublishNext(AvaloniaProperty.UnsetValue);
+            }
+        }
+
+        private void TemplatedParentChanged()
+        {
+            if (_target.TemplatedParent != null)
+            {
+                _target.TemplatedParent.PropertyChanged += TemplatedParentPropertyChanged;
+            }
+
+            PublishValue();
+        }
+
+        private void TargetPropertyChanged(object sender, AvaloniaPropertyChangedEventArgs e)
+        {
+            if (e.Property == StyledElement.TemplatedParentProperty)
+            {
+                var oldValue = (IAvaloniaObject)e.OldValue;
+                var newValue = (IAvaloniaObject)e.OldValue;
+
+                if (oldValue != null)
+                {
+                    oldValue.PropertyChanged -= TemplatedParentPropertyChanged;
+                }
+
+                TemplatedParentChanged();
+            }
+        }
+
+        private void TemplatedParentPropertyChanged(object sender, AvaloniaPropertyChangedEventArgs e)
+        {
+            if (e.Property == Property)
+            {
+                PublishNext(_target.TemplatedParent.GetValue(Property));
+            }
+        }
+    }
+}
diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/Converters/AvaloniaPropertyConverterTest.cs b/tests/Avalonia.Markup.Xaml.UnitTests/Converters/AvaloniaPropertyConverterTest.cs
index 8ccd9d94e0a..a028e246a4c 100644
--- a/tests/Avalonia.Markup.Xaml.UnitTests/Converters/AvaloniaPropertyConverterTest.cs
+++ b/tests/Avalonia.Markup.Xaml.UnitTests/Converters/AvaloniaPropertyConverterTest.cs
@@ -8,7 +8,6 @@
 using Avalonia.Styling;
 using Xunit;
 using System.ComponentModel;
-using Portable.Xaml.ComponentModel;
 using Portable.Xaml;
 using Portable.Xaml.Markup;
 
@@ -53,7 +52,17 @@ public void ConvertFrom_Finds_Attached_Property()
 
             Assert.Equal(AttachedOwner.AttachedProperty, result);
         }
-        
+
+        [Fact]
+        public void ConvertFrom_Finds_Attached_Property_With_Parentheses()
+        {
+            var target = new AvaloniaPropertyTypeConverter();
+            var context = CreateContext();
+            var result = target.ConvertFrom(context, null, "(AttachedOwner.Attached)");
+
+            Assert.Equal(AttachedOwner.AttachedProperty, result);
+        }
+
         private ITypeDescriptorContext CreateContext(Style style = null)
         {
             var tdMock = new Mock<ITypeDescriptorContext>();
diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/Data/BindingTests_TemplatedParent.cs b/tests/Avalonia.Markup.Xaml.UnitTests/Data/BindingTests_TemplatedParent.cs
index ab5b7e76a46..a9bea01fdeb 100644
--- a/tests/Avalonia.Markup.Xaml.UnitTests/Data/BindingTests_TemplatedParent.cs
+++ b/tests/Avalonia.Markup.Xaml.UnitTests/Data/BindingTests_TemplatedParent.cs
@@ -1,18 +1,12 @@
 // Copyright (c) The Avalonia Project. All rights reserved.
 // Licensed under the MIT license. See licence.md file in the project root for full license information.
 
-using System;
+using System.Linq;
 using System.Reactive.Linq;
-using System.Reactive.Subjects;
-using Moq;
 using Avalonia.Controls;
-using Avalonia.Data;
-using Avalonia.Styling;
-using Xunit;
-using System.Reactive.Disposables;
 using Avalonia.UnitTests;
 using Avalonia.VisualTree;
-using System.Linq;
+using Xunit;
 
 namespace Avalonia.Markup.Xaml.UnitTests.Data
 {
@@ -30,7 +24,7 @@ public void TemplateBinding_With_Null_Path_Works()
     <Button Name='button'>
        <Button.Template>
          <ControlTemplate>
-           <TextBlock Text='{TemplateBinding}'/>
+           <TextBlock Tag='{TemplateBinding}'/>
          </ControlTemplate>
        </Button.Template>
     </Button>
@@ -43,7 +37,7 @@ public void TemplateBinding_With_Null_Path_Works()
                 button.ApplyTemplate();
 
                 var textBlock = (TextBlock)button.GetVisualChildren().Single();
-                Assert.Equal("Avalonia.Controls.Button", textBlock.Text);
+                Assert.Same(button, textBlock.Tag);
             }
         }
     }
diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs
index c41cf4a5901..6777171e411 100644
--- a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs
+++ b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/BasicTests.cs
@@ -686,7 +686,7 @@ public void Control_Template_Is_Operational()
 <Window xmlns='https://github.com/avaloniaui'
                 xmlns:x='http://schemas.microsoft.com/winfx/2006/xaml'>
     <Window.Template>
-        <ControlTemplate>
+        <ControlTemplate TargetType='Window'>
             <ContentPresenter Name='PART_ContentPresenter'
                         Content='{TemplateBinding Content}'/>
         </ControlTemplate>

From be39c7cf513601bf89351f5485903a69fa0ba711 Mon Sep 17 00:00:00 2001
From: Steven Kirk <grokys@users.noreply.github.com>
Date: Mon, 25 Jun 2018 00:14:27 +0200
Subject: [PATCH 2/4] Don't need TemplateBindingExtension.

Can just use TemplateBinding directly.
---
 .../Avalonia.Markup.Xaml.csproj               |  1 -
 .../TemplateBindingExtension.cs               | 55 -------------------
 .../PortableXaml/AvaloniaXamlSchemaContext.cs |  1 -
 .../Avalonia.Markup/Data/TemplateBinding.cs   |  9 +++
 4 files changed, 9 insertions(+), 57 deletions(-)
 delete mode 100644 src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TemplateBindingExtension.cs

diff --git a/src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj b/src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj
index 9260a0c9a25..cdc22f41023 100644
--- a/src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj
+++ b/src/Markup/Avalonia.Markup.Xaml/Avalonia.Markup.Xaml.csproj
@@ -48,7 +48,6 @@
         <Compile Include="Converters\SelectorTypeConverter.cs" />
         <Compile Include="MarkupExtensions\BindingExtension.cs" />
         <Compile Include="MarkupExtensions\RelativeSourceExtension.cs" />
-        <Compile Include="MarkupExtensions\TemplateBindingExtension.cs" />
         <Compile Include="PortableXaml\AvaloniaTypeAttributeProvider.cs" />
         <Compile Include="PortableXaml\AvaloniaXamlType.cs" />
         <Compile Include="PortableXaml\TypeDescriptorExtensions.cs" />
diff --git a/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TemplateBindingExtension.cs b/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TemplateBindingExtension.cs
deleted file mode 100644
index 60b2b735584..00000000000
--- a/src/Markup/Avalonia.Markup.Xaml/MarkupExtensions/TemplateBindingExtension.cs
+++ /dev/null
@@ -1,55 +0,0 @@
-// Copyright (c) The Avalonia Project. All rights reserved.
-// Licensed under the MIT license. See licence.md file in the project root for full license information.
-
-using System;
-using Avalonia.Data;
-using Avalonia.Data.Converters;
-using Portable.Xaml.Markup;
-
-namespace Avalonia.Markup.Xaml.MarkupExtensions
-{
-    [MarkupExtensionReturnType(typeof(IBinding))]
-    public class TemplateBindingExtension : MarkupExtension
-    {
-        public TemplateBindingExtension()
-        {
-        }
-
-        public TemplateBindingExtension(AvaloniaProperty property)
-        {
-            Property = property;
-        }
-
-        public override object ProvideValue(IServiceProvider serviceProvider)
-        {
-            return new TemplateBinding
-            {
-                Converter = Converter,
-                ConverterParameter = ConverterParameter,
-                Mode = Mode,
-                Property = Property,
-            };
-        }
-
-        /// <summary>
-        /// Gets or sets the <see cref="IValueConverter"/> to use.
-        /// </summary>
-        public IValueConverter Converter { get; set; }
-
-        /// <summary>
-        /// Gets or sets a parameter to pass to <see cref="Converter"/>.
-        /// </summary>
-        public object ConverterParameter { get; set; }
-
-        /// <summary>
-        /// Gets or sets the binding mode.
-        /// </summary>
-        public BindingMode Mode { get; set; }
-
-        /// <summary>
-        /// Gets or sets the name of the source property on the templated parent.
-        /// </summary>
-        [ConstructorArgument("property")]
-        public AvaloniaProperty Property { get; set; }
-    }
-}
\ No newline at end of file
diff --git a/src/Markup/Avalonia.Markup.Xaml/PortableXaml/AvaloniaXamlSchemaContext.cs b/src/Markup/Avalonia.Markup.Xaml/PortableXaml/AvaloniaXamlSchemaContext.cs
index 7de3fcf46a0..70402aa7648 100644
--- a/src/Markup/Avalonia.Markup.Xaml/PortableXaml/AvaloniaXamlSchemaContext.cs
+++ b/src/Markup/Avalonia.Markup.Xaml/PortableXaml/AvaloniaXamlSchemaContext.cs
@@ -166,7 +166,6 @@ public override XamlType GetXamlType(Type type)
         {
             { typeof(Binding), typeof(BindingExtension) },
             { typeof(StyleInclude), typeof(StyleIncludeExtension) },
-            { typeof(TemplateBinding), typeof(TemplateBindingExtension) },
         };
 
         private XamlType GetAvaloniaXamlType(Type type)
diff --git a/src/Markup/Avalonia.Markup/Data/TemplateBinding.cs b/src/Markup/Avalonia.Markup/Data/TemplateBinding.cs
index 8402d882361..9a5aa41e1fd 100644
--- a/src/Markup/Avalonia.Markup/Data/TemplateBinding.cs
+++ b/src/Markup/Avalonia.Markup/Data/TemplateBinding.cs
@@ -17,6 +17,15 @@ public class TemplateBinding : SingleSubscriberObservableBase<object>,
         private IStyledElement _target;
         private Type _targetType;
 
+        public TemplateBinding()
+        {
+        }
+
+        public TemplateBinding(AvaloniaProperty property)
+        {
+            Property = property;
+        }
+
         /// <inheritdoc/>
         public InstancedBinding Initiate(
             IAvaloniaObject target,

From 03edafc0e12db28398ce3730afc2e036b53c3edd Mon Sep 17 00:00:00 2001
From: Steven Kirk <grokys@users.noreply.github.com>
Date: Mon, 25 Jun 2018 10:12:45 +0200
Subject: [PATCH 3/4] Removed debug code.

---
 .../Converters/AvaloniaPropertyTypeConverter.cs               | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs b/src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs
index 1fd73d5061e..63b7811dbc8 100644
--- a/src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs
+++ b/src/Markup/Avalonia.Markup.Xaml/Converters/AvaloniaPropertyTypeConverter.cs
@@ -29,10 +29,6 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
                 context.GetFirstAmbientValue<ControlTemplate>()?.TargetType ??
                 context.GetFirstAmbientValue<Style>()?.Selector?.TargetType;
 
-            var ipvt = context.GetService<IProvideValueTarget>();
-            var idtp = context.GetService<IDestinationTypeProvider>();
-            var ao = context.GetFirstAmbientValue<AvaloniaObject>();
-
             if (ownerType == null)
             {
                 throw new XamlLoadException(

From 8bd8a61142888faba20d41c8f9f5b22969dfa245 Mon Sep 17 00:00:00 2001
From: Steven Kirk <grokys@users.noreply.github.com>
Date: Mon, 25 Jun 2018 10:46:50 +0200
Subject: [PATCH 4/4] Throw if no matching property accessor found.

This shouldn't happen normally as `InpcPropertyAcessorPlugin` matches everything.
---
 src/Avalonia.Base/Data/Core/PropertyAccessorNode.cs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/Avalonia.Base/Data/Core/PropertyAccessorNode.cs b/src/Avalonia.Base/Data/Core/PropertyAccessorNode.cs
index 2565a34322c..e9831eb0479 100644
--- a/src/Avalonia.Base/Data/Core/PropertyAccessorNode.cs
+++ b/src/Avalonia.Base/Data/Core/PropertyAccessorNode.cs
@@ -53,6 +53,12 @@ protected override void StartListeningCore(WeakReference reference)
                 }
             }
 
+            if (accessor == null)
+            {
+                throw new NotSupportedException(
+                    $"Could not find a matching property accessor for {PropertyName}.");
+            }
+
             accessor.Subscribe(ValueChanged);
             _accessor = accessor;
         }