Add Cabal Helper cradle and tests #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
add-cabal-helper
branch
2 times, most recently
from
cb2dc05 to
841d0f1
Compare
fendor
commented
May 30, 2020
fendor
force-pushed
the
add-cabal-helper
branch
6 times, most recently
from
1183b71 to
5b9c659
Compare
Owner
|
Wow, that was fast! |
Avi-D-coder
requested changes
May 30, 2020
Owner
Avi-D-coder
left a comment
Avi-D-coder
left a comment
There was a problem hiding this comment.
Looks great, but I'd like this all to be behind a cabal flag.
Avi-D-coder
requested changes
May 31, 2020
Owner
Avi-D-coder
left a comment
Avi-D-coder
left a comment
There was a problem hiding this comment.
Once #4 (comment) is addressed this should be good to go.
It should be possible to select cabal-helper programmatically in the lib and via a command line flag a la #3.
fendor
force-pushed
the
add-cabal-helper
branch
3 times, most recently
from
dce5b4d to
74d4e31
Compare
Vastly copied from https://github.com/haskell/haskell-ide-engine/ Also, add a cabal flag to hide the cabal-helper dependency
Collaborator
Author
Collaborator
Author
|
Closed as it seems like we want to go a different way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vastly copied from https://github.com/haskell/haskell-ide-engine/
Copies tests and the cabal-helper cradle, does not modify any existing behaviour.