Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default sequenced dead letter queue provider. #355

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

gklijs
Copy link

@gklijs gklijs commented May 26, 2023

Set default sequenced dead letter queue provider, but allow disabling by setting the axon.mongo.event-handling.dlq-enabled property.

…e this by setting a the `axon.mongo.event-handling.dlq-enabled` property.
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, I doubted a little about defaulting the toggle to use a Mongo DLQ to true. However, users are still inclined to set the DLQ per processor on the properties regardless (which I think makes sense). The DLQ is quite a heavy tool, so enforcing it by default to any processor doesn't seem desirable to me.

Long story short, I agree with the logic. I only have a couple of JavaDoc complaints, so I'll approve preemptively.

Resolve JavaDoc concerns

#355
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@smcvb smcvb merged commit cdcd341 into master Jun 21, 2023
@smcvb smcvb deleted the set_dlq_provider branch June 21, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants