From ce36c13cfcf666f1bbaa1846d606a79dd33d6413 Mon Sep 17 00:00:00 2001 From: LHerskind Date: Sat, 27 Jan 2024 20:05:39 +0000 Subject: [PATCH] chore: address comment --- boxes/token/src/contracts/src/types/transparent_note.nr | 1 - .../token_blacklist_contract/src/types/transparent_note.nr | 1 - .../contracts/token_contract/src/types/transparent_note.nr | 1 - 3 files changed, 3 deletions(-) diff --git a/boxes/token/src/contracts/src/types/transparent_note.nr b/boxes/token/src/contracts/src/types/transparent_note.nr index f42de2e3ea2..361413bc82b 100644 --- a/boxes/token/src/contracts/src/types/transparent_note.nr +++ b/boxes/token/src/contracts/src/types/transparent_note.nr @@ -75,7 +75,6 @@ impl TransparentNote { } pub fn compute_nullifier_without_context(self) -> Field { - // TODO(#1386): should use `compute_note_hash_for_read_or_nullify` once public functions inject nonce! let siloed_note_hash = compute_note_hash_for_read_or_nullify(TransparentNoteMethods, self); // TODO(#1205) Should use a non-zero generator index. pedersen_hash([self.secret, siloed_note_hash],0) diff --git a/yarn-project/noir-contracts/contracts/token_blacklist_contract/src/types/transparent_note.nr b/yarn-project/noir-contracts/contracts/token_blacklist_contract/src/types/transparent_note.nr index a3741b4d604..36658d459cc 100644 --- a/yarn-project/noir-contracts/contracts/token_blacklist_contract/src/types/transparent_note.nr +++ b/yarn-project/noir-contracts/contracts/token_blacklist_contract/src/types/transparent_note.nr @@ -75,7 +75,6 @@ impl TransparentNote { } pub fn compute_nullifier_without_context(self) -> Field { - // TODO(#1386): should use `compute_note_hash_for_read_or_nullify` once public functions inject nonce! let siloed_note_hash = compute_note_hash_for_read_or_nullify(TransparentNoteMethods, self); // TODO(#1205) Should use a non-zero generator index. pedersen_hash([self.secret, siloed_note_hash],0) diff --git a/yarn-project/noir-contracts/contracts/token_contract/src/types/transparent_note.nr b/yarn-project/noir-contracts/contracts/token_contract/src/types/transparent_note.nr index f42de2e3ea2..361413bc82b 100644 --- a/yarn-project/noir-contracts/contracts/token_contract/src/types/transparent_note.nr +++ b/yarn-project/noir-contracts/contracts/token_contract/src/types/transparent_note.nr @@ -75,7 +75,6 @@ impl TransparentNote { } pub fn compute_nullifier_without_context(self) -> Field { - // TODO(#1386): should use `compute_note_hash_for_read_or_nullify` once public functions inject nonce! let siloed_note_hash = compute_note_hash_for_read_or_nullify(TransparentNoteMethods, self); // TODO(#1205) Should use a non-zero generator index. pedersen_hash([self.secret, siloed_note_hash],0)