Skip to content

Commit

Permalink
Updated all GitHub Actions to latest version to update to NodeJS 20 (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
pjlewisuk authored Apr 9, 2024
1 parent 5af2e1c commit 8d577a3
Show file tree
Hide file tree
Showing 23 changed files with 102 additions and 124 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/AKSC_Deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
AGNAME: ${{ steps.deployAks.outputs.AGNAME }}
steps:
# Login to Azure
- uses: azure/login@v1.4.6
- uses: azure/login@v2
name: Initial Login to Azure to Deploy
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
echo "AGNAME=$appGatewayName" >> $GITHUB_OUTPUT
# Re-Login to Azure if we're using the AKS RUN COMMAND
- uses: azure/login@v1.4.6
- uses: azure/login@v2
name: Initial Login to Azure to Deploy
if: inputs.postScriptParams && inputs.postScriptInvokeCommand == true
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/AksTroubleshooting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
run: az extension add -n log-analytics -y

- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: true
Expand Down Expand Up @@ -138,7 +138,7 @@ jobs:
if: always() && inputs.AGNAME != ''
steps:
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: true
Expand Down Expand Up @@ -233,7 +233,7 @@ jobs:
- name: Store any generated debug json files as artifacts
if: always()
uses: actions/upload-artifact@v3.1.2
uses: actions/upload-artifact@v4.3.1
with:
name: Troubleshooting-AGIC
path: debug*.*
Expand All @@ -252,7 +252,7 @@ jobs:
echo "LA workspace guid is ${{ inputs.LAWGUID }}"
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: true
Expand All @@ -275,7 +275,7 @@ jobs:
- name: Check Run Command
if: inputs.USERUNCMD == true
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
env:
AZCLIVERSION: latest
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/AppDeploy_AzureVote.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
AKSNAME: "${{ inputs.AKSNAME}}"
RG: "${{ inputs.RG }}"
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

- name: Job parameter inspection
run: |
Expand All @@ -79,7 +79,7 @@ jobs:
echo "AKS name is ${{ inputs.AKSNAME }}"
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: false
Expand Down Expand Up @@ -271,7 +271,7 @@ jobs:
- name: Store any generated debug files as artifacts
if: always()
uses: actions/upload-artifact@v3.1.2
uses: actions/upload-artifact@v4.3.1
with:
name: DebugFiles
path: debug*.json
4 changes: 2 additions & 2 deletions .github/workflows/AppDeploy_JavaApp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
runs-on: ubuntu-latest
concurrency: "Ag-${{ inputs.AGNAME}}" #AppGateway doesn't like concurrent updates
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

- name: Job parameter inspection
run: |
Expand All @@ -72,7 +72,7 @@ jobs:
echo "CertManager version is ${{ inputs.CERTMANAGERVERSION }}"
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: false
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/ByoVnetCI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
needs: [Validation]
if: github.event_name != 'pull_request' || github.event.inputs.doWellArchitected == 'true' || contains( github.event.pull_request.labels.*.name, 'test-deploy-byoconfig')
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

# PSRule does this cool thing where it traverse the parameter file through to the arm template
# PSRule performs IaC recommendations of the template.
Expand Down Expand Up @@ -148,7 +148,7 @@ jobs:
PARAMOVERRIDES: ${{ steps.imperitiveparams.outputs.PARAMOVERRIDES}} #This won't work if the string includes any SECRETS!!!
PARAMOVERRIDESNOSECRETS: ${{ steps.imperitiveparams.outputs.PARAMOVERRIDESNOSECRETS}}
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

- name: Job parameter check
run: |
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
echo "NEWRESNAME=$NEWRESNAME" >> $GITHUB_OUTPUT
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
Expand All @@ -232,7 +232,7 @@ jobs:
if: github.event.inputs.doVerifySteps == 'true'
env:
RG: ${{ steps.params.outputs.RESOURCEGROUP }}
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
with:
azcliversion: ${{ env.AZCLIVERSION }}
inlineScript: |
Expand Down Expand Up @@ -288,7 +288,7 @@ jobs:
}
- name: Create Parameter file imperative override string
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
id: imperitiveparams
env:
RG: ${{ steps.params.outputs.RESOURCEGROUP }}
Expand All @@ -304,7 +304,7 @@ jobs:
echo "PARAMOVERRIDESNOSECRETS=$PARAMOVERRIDESNOSECRETS" >> $GITHUB_OUTPUT
- name: Validate Infrastructure deployment
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
env:
RG: ${{ steps.params.outputs.RESOURCEGROUP }}
with:
Expand All @@ -319,7 +319,7 @@ jobs:
az deployment group validate -f bicep/main.bicep -g $RG -p ${{ env.ParamFilePath }} -p $PARAMS --verbose
- name: What If (GA edge Az cli version) (has issues)
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
id: edgeWhatIf
env:
RG: ${{ steps.params.outputs.RESOURCEGROUP }}
Expand All @@ -346,7 +346,7 @@ jobs:
echo "edgeSuccess=true" >> $GITHUB_OUTPUT
- name: What If (No Secrets param string, used for Cost Estimate)
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
env:
RG: ${{ steps.params.outputs.RESOURCEGROUP }}
continue-on-error: true
Expand All @@ -367,7 +367,7 @@ jobs:
cat $WHATIFPATH
- name: What If (workaround task)
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
continue-on-error: true #Setting to true due to bug in the AzureCLI https://github.com/Azure/azure-cli/issues/19850
if: steps.edgeWhatIf.outputs.edgeSuccess != 'true'
env:
Expand Down Expand Up @@ -481,7 +481,7 @@ jobs:

if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || github.ref == 'refs/heads/develop' || contains( github.event.pull_request.labels.*.name, 'test-deploy-byoconfig')
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

- name: Job parameter check
if: github.event.inputs.doDebugSteps == 'true'
Expand All @@ -505,7 +505,7 @@ jobs:
}
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
Expand All @@ -516,7 +516,7 @@ jobs:

- name: Deploy Infrastructure
id: deployAks
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
with:
azcliversion: ${{ env.AZCLIVERSION }}
inlineScript: |
Expand Down Expand Up @@ -550,7 +550,7 @@ jobs:
- name: Enable AGIC Addon
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
if: ${{ needs.Deploy.outputs.AGNAME}} != ''
with:
azcliversion: ${{ env.AZCLIVERSION }}
Expand Down Expand Up @@ -728,7 +728,7 @@ jobs:
env:
RG: ${{ needs.Validation.outputs.RESOURCEGROUP }}
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

- name: Param check
if: github.event.inputs.doDebugSteps == 'true'
Expand All @@ -740,7 +740,7 @@ jobs:
echo "AKS name is ${{ needs.Deploy.outputs.AKSNAME }}"
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/ByoVnetPrivateCI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
environment: ${{ github.event.inputs.environment }}
if: github.event_name == 'pull_request' || github.event.inputs.doWellArchitected == 'true'
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

# PSRule does this cool thing where it traverse the parameter file through to the arm template
# PSRule performs IaC recommendations of the template.
Expand Down Expand Up @@ -160,7 +160,7 @@ jobs:
RESNAME: ${{ steps.params.outputs.NEWRESNAME}}

steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

- name: Job parameter check
run: |
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:
echo "NEWRESNAME=$NEWRESNAME" >> $GITHUB_OUTPUT
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: false
Expand All @@ -226,7 +226,7 @@ jobs:
- name: Verify any active Azure Resource Group Deployments #These can mess up our deployment
if: github.event.inputs.doDebugSteps == 'true'
id: activedeps
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
with:
azcliversion: ${{ env.AZCLIVERSION }}
inlineScript: |
Expand All @@ -247,15 +247,15 @@ jobs:
fi
- name: Validate Infrastructure deployment
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
with:
azcliversion: ${{ env.AZCLIVERSION }}
inlineScript: |
az deployment group validate -f bicep/main.bicep -g $RG -p ${{ env.ParamFilePath }} -p resourceName=${{ steps.params.outputs.NEWRESNAME}} location=${{ steps.params.outputs.REGION}}
- name: What If
if: github.event.inputs.doDebugSteps == 'true'
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
continue-on-error: ${{ secrets.ISAZCLIWHATIFUNRELIABLE == 'true' }}
with:
azcliversion: ${{ env.AZCLIVERSION }}
Expand All @@ -277,7 +277,7 @@ jobs:
REGION: ${{ needs.Validation.outputs.REGION }}
RESNAME: ${{ needs.Validation.outputs.RESNAME }}
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

- name: Job parameter check
if: github.event.inputs.doVerifySteps == 'true'
Expand All @@ -304,7 +304,7 @@ jobs:
}
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: true
Expand All @@ -313,7 +313,7 @@ jobs:

- name: Deploy Infrastructure
id: deployAks
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
with:
azcliversion: ${{ env.AZCLIVERSION }}
inlineScript: |
Expand Down Expand Up @@ -348,7 +348,7 @@ jobs:
sleep $DELAY
- name: Enable AGIC Addon
uses: Azure/cli@v1.0.7
uses: Azure/cli@v2
with:
azcliversion: ${{ env.AZCLIVERSION }}
inlineScript: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/Lighthouse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,20 @@ jobs:
lighthouse:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1

- name: Prep file system
run: mkdir ${{ env.outputdir }}

- name: Lighthouse Checks
uses: foo-software/lighthouse-check-action@v9.1.0
uses: foo-software/lighthouse-check-action@v10.0.0
id: lighthouseCheck
with:
urls: ${{ env.websiteUrl }}
outputDirectory: ${{ env.outputdir }}

- name: Upload Lighthouse report
uses: actions/upload-artifact@v3.1.2
uses: actions/upload-artifact@v4.3.1
with:
name: Lighthouse reports
path: ${{ env.outputdir }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/PostDeploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
RG: "${{ inputs.RG }}"
AKSNAME: "${{ inputs.AKSNAME }}"
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1
name: Script file download

- name: Job parameter inspection
Expand All @@ -53,7 +53,7 @@ jobs:
echo "CertManager version is ${{ inputs.CERTMANAGERVERSION }}"
- name: Azure Login
uses: Azure/login@v1.4.6
uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: false
Expand Down
Loading

0 comments on commit 8d577a3

Please sign in to comment.