Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep refactor #470

Merged
merged 15 commits into from
Mar 16, 2023
Merged

Bicep refactor #470

merged 15 commits into from
Mar 16, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Nov 24, 2022

PR Summary

Numerous bicep improvements

  1. Including deployment names in module deplyoment as a prefix
  2. Setting the Log analytics sku explicitly (helps the whatif operation)
  3. Setting a better name for the Managed Identity that is used as part of the importImages module (the autogenerated name doesn't include azure region, so can trip up deployments to multiple regions in the same subscription)
  4. Fixing some bicep v0.15 linter warnings (Old Api versions and json('null'))
  5. Adding Application Gateway Request Routing Priority (required by api-version 2021-08-01 and newer)

Make sure to test in PR

  • Importing container images to eval new managed identity name
  • Container V2 Logs

Test results

Explicit Managed Id name;
image

Container v2;
image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby Gordonby added the enhancement New feature or request label Nov 24, 2022
@Gordonby Gordonby self-assigned this Nov 24, 2022
@github-actions
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Dec 25, 2022
@Gordonby Gordonby removed the stale An issue that hasn't had a lot of love recently label Jan 13, 2023
@Gordonby Gordonby added this to the 0.9.8 milestone Jan 17, 2023
@Gordonby Gordonby modified the milestones: 0.9.8, 0.9.9, 0.9.10 Jan 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Mar 3, 2023
@github-actions github-actions bot removed the helper-ui label Mar 6, 2023
@github-actions github-actions bot added Keep Open and removed stale An issue that hasn't had a lot of love recently labels Mar 7, 2023
@Gordonby Gordonby requested a review from khowling March 15, 2023 12:11
@Gordonby Gordonby marked this pull request as ready for review March 15, 2023 12:11
@Gordonby Gordonby enabled auto-merge (squash) March 16, 2023 08:01
@Gordonby Gordonby merged commit b3f609b into main Mar 16, 2023
@Gordonby Gordonby deleted the gb-biceppolish branch March 16, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Keep Open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants