-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainerLogsV2 and Basic Logs support #492
Conversation
…v2 log implementation
93c5868
to
993e56e
Compare
👋 @khowling, incorporated feedback from our PR discussion. Also added another function in addons.js to ensure any features dependent on the ContainerLogsV2 schema are disabled as well (at present it only accommodates for the Basic Logs feature). This avoids the scenario where the user selects on Basic Logs (which automatically selects the ContainerLogsV2 feature) and then decides to disable the ContainerLogsV2 feature (i.e safety guard in both directions now). |
hey @samaea , looking good! I just tested the UI, and one small thing, in Monitoring, If I select 'Azure Monitor for Containers', then select the V2 Logs, the parameters appear on the deployment command as expected. But it I then select 'None' for Monitoring, the V2 log parameters still appear. To fix this, can you add an additional check in the deployment logic, take a look at this as an example |
Hey @khowling - great catch! All done. :) |
PR Summary
Addresses issue #437.
In addition, added:-
PR Checklist