Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper: Windows refinements #513

Merged
merged 13 commits into from
Feb 22, 2023
Merged

Helper: Windows refinements #513

merged 13 commits into from
Feb 22, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Jan 31, 2023 •
edited
Loading

PR Summary

Refines the Helper guidance for Windows workloads.

  1. Prevents Kubenet + Windows

image

  1. Removing Windows Server 2019 as an option & default

image

  1. Creates error if Private Cluster + Windows to notify post deploy steps are impossible

image

  1. Stronger message if unsupported ingress controller is selected

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

Gordon Byers added 7 commits January 31, 2023 16:49
Create aspnetapp.yml
a8fa37b
Merge branch 'main' of https://github.com/Azure/AKS-Construction into…
51779ba 
… gb-windowswebworkload
removing push trigger
205b99c
Merge branch 'main' of https://github.com/Azure/AKS-Construction into…
861c649 
… gb-windowswebworkload

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
removing windows 2019 as an option
7a85347 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
stopping kubenet + windows
595e3be 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
more windows guidance
f48eadd 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby changed the title Windows sample workload & docs Helper: Windows refinements Feb 21, 2023
@Gordonby Gordonby requested a review from khowling February 21, 2023 09:39
@Gordonby Gordonby marked this pull request as ready for review February 21, 2023 09:40
typo
31727da 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby self-assigned this Feb 21, 2023
@Gordonby Gordonby enabled auto-merge (squash) February 22, 2023 12:50
@Gordonby Gordonby merged commit 1cb427e into main Feb 22, 2023
@Gordonby Gordonby deleted the gb-windowswebworkload branch February 22, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattLeach25 MattLeach25 MattLeach25 approved these changes

@khowling khowling Awaiting requested review from khowling

Assignees

@Gordonby Gordonby

Labels
helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gordonby @MattLeach25