Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow refinements #514

Merged
merged 29 commits into from
Jan 31, 2023
Merged

Workflow refinements #514

merged 29 commits into from
Jan 31, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Jan 31, 2023 •
edited
Loading

PR Summary

A small number of workflow refinements

Byo workflow

  1. Stopping the push trigger - this was just excessive, but also caused issues with Azure/Login federated credential claims
  2. Using pre-release version of PSRule for Azure to address a reported bug
  3. Closes Optimise infra CI/CD during PR #506 by not running Infra deployments on draft PR's
  4. Using Prerelease version of PSRule to pull in bugfix from main branch

Private workflow

  1. Stopping the push trigger - this was just excessive, but also caused issues with Azure/Login federated credential claims
  2. Using pre-release version of PSRule for Azure to address a reported bug
  3. Closes Optimise infra CI/CD during PR #506 by not running Infra deployments on draft PR's

Standard CI workflow

  1. Stopping the push trigger - this was just excessive, but also caused issues with Azure/Login federated credential claims
  2. Closes Optimise infra CI/CD during PR #506 by not running Infra deployments on draft PR's

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby Gordonby temporarily deployed to csu January 31, 2023 18:01 — with GitHub Actions Inactive
@Gordonby Gordonby self-assigned this Jan 31, 2023
@Gordonby Gordonby added the ci-cd sample 🤖 Sample code in a GitHub action workflow label Jan 31, 2023
@Gordonby Gordonby marked this pull request as ready for review January 31, 2023 20:41
@Gordonby Gordonby marked this pull request as draft January 31, 2023 20:43
@Gordonby Gordonby marked this pull request as ready for review January 31, 2023 21:37
@Gordonby Gordonby enabled auto-merge (squash) January 31, 2023 21:37
@Gordonby Gordonby merged commit 2a3db81 into main Jan 31, 2023
@Gordonby Gordonby deleted the gb-wellarchfixup branch January 31, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liammoat liammoat liammoat approved these changes

Assignees

@Gordonby Gordonby

Labels
ci-cd sample 🤖 Sample code in a GitHub action workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise infra CI/CD during PR
2 participants
@Gordonby @liammoat