Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the non-PII telemetry capture to improve the user experience #539

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Enhance the non-PII telemetry capture to improve the user experience #539

merged 6 commits into from
Mar 15, 2023

Conversation

samaea
Copy link
Contributor

@samaea samaea commented Mar 13, 2023 •
edited
Loading

PR Summary

Addresses this issue:- #521.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

image

@samaea samaea requested review from khowling and Gordonby March 13, 2023 21:39
Gordonby
Gordonby previously approved these changes Mar 14, 2023
View reviewed changes
khowling
khowling reviewed Mar 15, 2023
View reviewed changes
helper/src/components/portalnav.js Outdated Show resolved Hide resolved
helper/src/components/portalnav.js Outdated Show resolved Hide resolved
helper/src/components/portalnav.js Outdated Show resolved Hide resolved
helper/src/components/portalnav.js Show resolved Hide resolved
helper/src/components/portalnav.js Outdated Show resolved Hide resolved
@Gordonby Gordonby requested a review from khowling March 15, 2023 12:22
@Gordonby Gordonby enabled auto-merge (squash) March 15, 2023 12:22
khowling
khowling previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for incorporating thoes changes, look good

@samaea samaea requested a review from khowling March 15, 2023 22:08
@Gordonby Gordonby merged commit 0f2054b into main Mar 15, 2023
@Gordonby Gordonby deleted the se-telemetry branch March 15, 2023 23:13
@Gordonby Gordonby mentioned this pull request Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

@Gordonby Gordonby Gordonby left review comments

Assignees

@samaea samaea

Labels
helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samaea @khowling @Gordonby