Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall SKU selection bugfix #545

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Firewall SKU selection bugfix #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e3203f
passing sku down to module
Mar 16, 2023
248b242
Merge branch 'main' into gb-azfwsubnetbug
naioja Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bicep/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ module network './network.bicep' = if (custom_vnet) {
ingressApplicationGateway: ingressApplicationGateway
vnetAppGatewaySubnetAddressPrefix: vnetAppGatewaySubnetAddressPrefix
azureFirewalls: azureFirewalls
azureFirewallsSku: azureFirewallSku
vnetFirewallSubnetAddressPrefix: vnetFirewallSubnetAddressPrefix
vnetFirewallManagementSubnetAddressPrefix: vnetFirewallManagementSubnetAddressPrefix
privateLinks: privateLinks
Expand Down
2 changes: 1 addition & 1 deletion bicep/network.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ output vnetId string = vnet.id
output vnetName string = vnet.name
output aksSubnetId string = resourceId('Microsoft.Network/virtualNetworks/subnets', vnet.name, aks_subnet_name)
output fwSubnetId string = azureFirewalls ? '${vnet.id}/subnets/${fw_subnet_name}' : ''
output fwMgmtSubnetId string = azureFirewalls ? '${vnet.id}/subnets/${fwmgmt_subnet_name}' : ''
output fwMgmtSubnetId string = azureFirewallsManagementSeperation ? '${vnet.id}/subnets/${fwmgmt_subnet_name}' : ''
output acrPoolSubnetId string = acrPrivatePool ? '${vnet.id}/subnets/${acrpool_subnet_name}' : ''
output appGwSubnetId string = resourceId('Microsoft.Network/virtualNetworks/subnets', vnet.name, appgw_subnet_name)
output privateLinkSubnetId string = resourceId('Microsoft.Network/virtualNetworks/subnets', vnet.name, private_link_subnet_name)
Expand Down