Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform bumps and bugfix #557

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Terraform bumps and bugfix #557

merged 3 commits into from
Mar 22, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Mar 22, 2023 •
edited
Loading

PR Summary

  1. Bumps required version of tf and providers
  2. Expanded outputs to aid debugging
  3. http provider deprecated warning - Closes Terraform implementation - deprecated warning #556
  4. http provider swap from client_id to object_id (emerged bug, likely provider)

Tested with big env config.
works great

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby Gordonby added the helper-ui 🧙‍♀️ An issue with the UI in the helper label Mar 22, 2023
@Gordonby Gordonby self-assigned this Mar 22, 2023
@Gordonby Gordonby requested a review from a team March 22, 2023 09:22
@Gordonby Gordonby merged commit 9d9df21 into main Mar 22, 2023
@Gordonby Gordonby deleted the gb-tfupdate branch March 22, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattLeach25 MattLeach25 MattLeach25 approved these changes

Assignees

@Gordonby Gordonby

Labels
helper-ui 🧙‍♀️ An issue with the UI in the helper helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform implementation - deprecated warning
2 participants
@Gordonby @MattLeach25