Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Old Role Assignments in CI resource group #561

Merged
merged 12 commits into from
Mar 30, 2023
Merged

Cleanup Old Role Assignments in CI resource group #561

merged 12 commits into from
Mar 30, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Mar 27, 2023 •
edited
Loading

PR Summary

Closes #555

Adds a step to the cleanup script that deletes orphaned role assignments from the Resource Group

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby Gordonby added the ci-cd sample 🤖 Sample code in a GitHub action workflow label Mar 27, 2023
@Gordonby Gordonby self-assigned this Mar 27, 2023
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 21:49 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 22:03 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 22:30 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 22:31 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 22:56 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:00 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:00 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:00 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:00 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:02 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:02 — with GitHub Actions Inactive
@Gordonby Gordonby requested a deployment to csu March 27, 2023 23:02 — with GitHub Actions Abandoned
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:02 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:02 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:02 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:02 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:07 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 27, 2023 23:12 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 28, 2023 13:05 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 28, 2023 13:06 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 28, 2023 13:07 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 28, 2023 13:07 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu March 28, 2023 13:12 — with GitHub Actions Inactive
@Gordonby Gordonby added test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge labels Mar 29, 2023
@Gordonby Gordonby marked this pull request as ready for review March 29, 2023 08:58
@Gordonby Gordonby temporarily deployed to csu March 29, 2023 12:28 — with GitHub Actions Inactive
@Gordonby Gordonby marked this pull request as draft March 29, 2023 12:57
@Gordonby Gordonby marked this pull request as ready for review March 30, 2023 12:13
@Gordonby Gordonby temporarily deployed to csu March 30, 2023 12:27 — with GitHub Actions Inactive
@Gordonby Gordonby requested a review from a team March 30, 2023 12:30
@Gordonby Gordonby enabled auto-merge (squash) March 30, 2023 12:37
@Gordonby Gordonby merged commit 400b167 into main Mar 30, 2023
@Gordonby Gordonby deleted the gb-cleanuprgrole branch March 30, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattLeach25 MattLeach25 MattLeach25 approved these changes

Assignees

@Gordonby Gordonby

Labels
ci-cd sample 🤖 Sample code in a GitHub action workflow test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CICD: Enhance cleanupRg.yml with RG RoleAssignment cleanup
2 participants
@Gordonby @MattLeach25