Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Se podnet #570

Merged
merged 5 commits into from
May 5, 2023
Merged

Se podnet #570

merged 5 commits into from
May 5, 2023

Conversation

samaea
Copy link
Contributor

@samaea samaea commented Apr 15, 2023

PR Summary

Addressing customer issue:- #569.

The Azure CNI networking for dynamic allocation of IPs feature in AKSC has not been implemented inline with our documentation:- https://learn.microsoft.com/en-us/azure/aks/configure-azure-cni-dynamic-ip-allocation. For example, when selecting Dynamic IP as a feature in AKSC, only one subnet (node) is deployed without a pod subnet. In addition, there isn't an option to do BYO vNet and referencing the pod subnet (only an option present for referencing the node subnet). This results in the Subnet IP Usage Workbook[1] not to function correctly due to CNI Dynamic IP allocation implementation not being configured correctly.

[1] https://learn.microsoft.com/en-us/azure/aks/configure-azure-cni#monitor-ip-subnet-usage

Bicep changes implemented:-

  • Changes to incorporate the provisioning of a pod subnet when custom vNets is selected.
  • BYO AKSPodSubnetId to link an existing pod subnet within an existing vnet.

Helper changes:-

  • UI change to introduce a text field to reference the BYO AKSPodSubnetId that shows when Azure CNI Dynamic IP allocation is selected.

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue (Customer reported offline, but no issued filed).
  • Screenshot of UI changes (if PR includes UI changes)

Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Custom Networking deploys fine

Just a naming issue to tweak

image

bicep/network.bicep Outdated Show resolved Hide resolved
@samaea samaea enabled auto-merge (squash) May 5, 2023 10:40
@samaea samaea merged commit e8882cb into main May 5, 2023
@samaea samaea deleted the se-podnet branch May 5, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure CNI Dynamic IP allocation + extended subset support lacking the provision of a pod subnet.
2 participants