Preview feature UI dialog popup #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gordonby
changed the title
|
Looks good, i do think we can make the link more accessible to the user by adding another button to the dialog footer which will open the link in a new window/tab. https://developer.microsoft.com/en-us/fluentui#/controls/web/dialog#usage |
|
@Gordonby Thank you for reviewing. I've made changes to allow someone to open the link in a new tab.
|
Gordonby
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This closes #421 and enables dialogs https://developer.microsoft.com/en-us/fluentui#/controls/web/dialog when preview* features are clicked as shown below
PR Checklist