refactor templatize ev2 package #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoberle
requested review from
bennerv,
janboll,
weinong,
whober0521 and
tony-schndr
as code owners
geoberle
changed the title
janboll
requested changes
Nov 25, 2024
|
Please rebase pull request. |
| @@ -231,3 +233,78 @@ func TestConvertToInterface(t *testing.T) { | |||
| assert.IsType(t, expected, map[string]any{}) | |||
| assert.IsType(t, expected["key2"], map[string]any{}) | |||
| } | |||
|
|
|||
| func TestPreprocessContent(t *testing.T) { | |||
| fileContent, err := os.ReadFile("../../testdata/test.bicepparam") | |||
There was a problem hiding this comment.
Consider //go:embed for static test data, much faster.
There was a problem hiding this comment.
i'll do some readup on go:embed. ty
geoberle
force-pushed
the
ev2-pipeline-tests
branch
from
de809a7
to
1d13826
Compare
* `PrecompilePipelineForEV2` renamed to `PrecompilePipelineFileForEV2` * `PrecompilePipelineForEV2` reintroduced but returns a parsed `pipeline.Pipeline` struct * refactoring for testability Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
geoberle
force-pushed
the
ev2-pipeline-tests
branch
from
1d13826
to
ad2c1ff
Compare
Co-authored-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
geoberle
force-pushed
the
ev2-pipeline-tests
branch
from
3e780ee
to
caf2cc7
Compare
Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
geoberle
force-pushed
the
ev2-pipeline-tests
branch
from
caf2cc7
to
d3807c0
Compare
whober0521
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
PrecompilePipelineForEV2renamed toPrecompilePipelineFileForEV2PrecompilePipelineForEV2reintroduced but returns a parsedpipeline.Pipelinestructconfig.Pipelinesub-structsNewEv2ConfigReplacementsJira:
Link to demo recording:
Special notes for your reviewer