Remove identifier uris for aro SP as it's not used #1816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
ADO-12455056
Fixes breaking AAD change in Azure: https://docs.microsoft.com/en-us/azure/active-directory/develop/reference-breaking-changes#appid-uri-in-single-tenant-applications-will-require-use-of-default-scheme-or-verified-domains
What this PR does / why we need it:
We can't create service principals in single tenants (customer tenants) with an unverified custom domain (az.aro.azure.com). I don't believe we're even using the
identifier_uris
field at all in the app registration as well.Test plan for issue:
Create a cluster using
CLUSTER=test go run ./hack/cluster create
Create a cluster using
az aro create
Is there any documentation that needs to be updated for this PR?
Not that I'm aware of.