Skip to content

Fix reference error in navigator detection #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix reference error in navigator detection #82

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3fab94
Fix reference error in navigator detection
Eskibear Jul 25, 2024
76f30d5
add test cases mocking web/webworker env
Eskibear Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/requestTracing/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ function isWebWorker() {
// https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope
const workerGlobalScopeDefined = typeof WorkerGlobalScope !== "undefined";
// https://developer.mozilla.org/en-US/docs/Web/API/WorkerNavigator
const isNavigatorDefinedAsExpected = typeof navigator === "object" && typeof WorkerNavigator !== "function" && navigator instanceof WorkerNavigator;
const isNavigatorDefinedAsExpected = typeof navigator === "object" && typeof WorkerNavigator === "function" && navigator instanceof WorkerNavigator;
// https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Using_web_workers#importing_scripts_and_libraries
const importScriptsAsGlobalFunction = typeof importScripts === "function";

Expand Down