Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README #1512

Merged
merged 14 commits into from
Jan 17, 2023
Merged

Add README #1512

merged 14 commits into from
Jan 17, 2023

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Jan 17, 2023

Main Code Changes

  • Update extension name from @microsoft/logic-apps-vscode-extension to logic-apps-vscode-extension as there is no support for scoped naming in VS Code Marketplace
  • Add azurite auto-generated files to .funcignore and .gitignore
  • Add README.md, LICENSE.md and CHANGELO.md inside extension folder
  • Add architecture image
  • Add vscode designer extension mdx

README Implementation

Screen.Recording.2023-01-17.at.10.07.55.AM.mov

AB#16820035

@ccastrotrejo ccastrotrejo marked this pull request as ready for review January 17, 2023 16:15
@ccastrotrejo ccastrotrejo merged commit 70f6016 into main Jan 17, 2023
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/readme branch January 17, 2023 21:39
@ecfan
Copy link
Member

ecfan commented Jan 17, 2023

@ccastrotrejo: Found many wording issues with this README, but I see you already merged the changes. I spent at least 30-45 minutes on this.

@ccastrotrejo
Copy link
Contributor Author

Hi @ecfan I can modify it in another PR. Please let me know what the wording issues are and sorry about the early merging.

@ecfan
Copy link
Member

ecfan commented Jan 17, 2023

@ccastrotrejo: They're all in the comments.

Copy link
Member

@ecfan ecfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many comments and revisions suggested.

apps/vs-code-designer/src/CHANGELOG.md Show resolved Hide resolved
apps/vs-code-designer/src/CHANGELOG.md Show resolved Hide resolved
apps/vs-code-designer/src/CHANGELOG.md Show resolved Hide resolved
apps/vs-code-designer/src/CHANGELOG.md Show resolved Hide resolved
apps/vs-code-designer/src/CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@ecfan ecfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many comments and revisions suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants