Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cgroups api refactor for v2 #3096

Merged
merged 15 commits into from
Apr 5, 2024

Commits on Mar 15, 2024

  1. Cgroups api refactor (#6)

    * Initial changes for log collector cgroups v2 support
    
    * Fix pylint issues
    
    * Fix pylint issues
    
    * Fix pylint issues
    
    * Check that both controllers are mounted in the chosen cgroups version for log collector
    
    * Fix regex
    
    * Update test_agent unit tests
    
    * Fix unit tests
    
    * Update format strings
    
    * Fix broken cgroupconfigurator unit tests
    
    * pyling
    
    * Fix cgroups api unit tests
    
    * Ignore unused args
    
    * Ignore unused args
    
    * Add cgroup configurator tests
    
    * v2 required check in parent cgroup
    
    * unit tests is_controller_enabled
    
    * Fix test failure and pylint:
    
    * pylint
    
    * Update agent checks
    
    * Fix controller enable logic and unit tests
    
    * Remove changes to collect logs
    
    * Fix pylint
    
    * Add e2e test for v2
    maddieford authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9501707 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Fix log warnings

    maddieford committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bd9caff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    689aacc View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    f9f5286 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Address PR comments (#7)

    * get_cgroup_api should raise exception when controllers not mounted
    
    * Combine cgroups_supported() check
    
    * Combine SystemdCgroupsApi and CGroupApi classes
    
    * fix pylint and tests with sudo
    
    * Rename SystemdCgroupsApi to SystemdCgroupApi
    
    * Cgroup should be singular when referring to the APi
    
    * Unimpleneted methods should raise NotImplementederror
    
    * Check for cpu,cpuacct
    
    * v2 start extension command should not be implemented
    
    * log_cgorup_info and log_cgroup_warning should be in cgroupapi
    
    * Systemd check should come before api
    
    * Explicitly check for empty dict
    
    * Only check if controllers are enabled at root for v2
    
    * Remove unnecessary mocked paths in mock cgroup env
    
    * V2 does not have concept of mounting controllers
    
    * Fix super call for python 2
    
    * get_cgroup_api should be function
    
    * Move logging functions up
    
    * Use stat -f to get cgroup mode
    
    * Mock hybrid path
    
    * Fix unit tests:
    
    * Debug tests
    
    * Debug tests
    
    * Debug unit tests
    
    * Fix unit tests
    
    * Fix pylint
    
    * Fix e2e test for v2
    
    * Fix e2e test
    
    * Fix e2e test
    
    * Fix e2e test
    
    * Combine common implementations
    maddieford authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0802d25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68dd2bd View commit details
    Browse the repository at this point in the history
  3. Improve comments

    maddieford committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cabfc70 View commit details
    Browse the repository at this point in the history
  4. Pylint

    maddieford committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    00b9c3e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Address PR comments (#8)

    * Run unit tests
    
    * Clean up drop in files if cgroups are disabled
    
    * Init values for cgroup apis
    
    * Rever test change
    maddieford authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    530ed56 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    3cc51db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81a6926 View commit details
    Browse the repository at this point in the history
  3. Fix conflict after merge

    maddieford committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7bc072e View commit details
    Browse the repository at this point in the history
  4. Merge issues (#10)

    * Fix merge issues
    
    * Fix unit tests
    maddieford authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6c3da64 View commit details
    Browse the repository at this point in the history
  5. get_cgroup_api raises InvalidCroupMountpointException (#11)

    * get_cgroup_api can raise InvalidCgroupMountpointException
    
    * Add unit test for agent
    maddieford authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6b309a6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    35ca335 View commit details
    Browse the repository at this point in the history