Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to SNI based authentication for aad app (#3137) #3174

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Switching to SNI based authentication for aad app (#3137) #3174

merged 1 commit into from
Aug 13, 2024

Conversation

maddieford
Copy link
Contributor

  • SNI auth

  • new env var

  • pylint

(cherry picked from commit 81140ee)

Description

Issue #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@nagworld9 @maddieford
Switching to SNI based authentication for aad app (Azure#3137)
d169f66 
* SNI auth

* new env var

* pylint

(cherry picked from commit 81140ee)
@maddieford maddieford merged commit fb372d9 into Azure:hotfix-2.11.1.9 Aug 13, 2024
8 of 9 checks passed
@maddieford maddieford deleted the cherrypick_bvt_fix branch August 13, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagworld9 nagworld9 nagworld9 approved these changes

@narrieta narrieta Awaiting requested review from narrieta narrieta is a code owner

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddieford @nagworld9