-
Notifications
You must be signed in to change notification settings - Fork 560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, though I have small concerns to make sure we can investigate/manage clusters if the the customer specifies a white list. But that is a discussion to be had when we enable the feature in AKS
Codecov Report
@@ Coverage Diff @@
## master #3582 +/- ##
=======================================
Coverage 55.55% 55.55%
=======================================
Files 107 107
Lines 16181 16181
=======================================
Hits 8989 8989
Misses 6440 6440
Partials 752 752 |
@CecileRobertMichon does it look good now? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, weinong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: