Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

added a property for aks #3582

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Conversation

weinong
Copy link
Contributor

@weinong weinong commented Jul 28, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@ghost ghost assigned weinong Jul 28, 2018
@ghost ghost added the in progress label Jul 28, 2018
@acs-bot acs-bot added size/S and removed size/XS labels Jul 29, 2018
Copy link
Contributor

@JackQuincy JackQuincy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, though I have small concerns to make sure we can investigate/manage clusters if the the customer specifies a white list. But that is a discussion to be had when we enable the feature in AKS

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #3582 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3582   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files         107      107           
  Lines       16181    16181           
=======================================
  Hits         8989     8989           
  Misses       6440     6440           
  Partials      752      752

@weinong
Copy link
Contributor Author

weinong commented Jul 31, 2018

@CecileRobertMichon does it look good now?

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Jul 31, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, weinong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit d6f61e0 into Azure:master Jul 31, 2018
@ghost ghost removed the in progress label Jul 31, 2018
jackfrancis pushed a commit that referenced this pull request Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants