Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

restore exechealthz defs for back compat #3620

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Aug 6, 2018

What this PR does / why we need it:
AKS using acs-engine had a malformed image tag with the healthz container in kube-dns for 1.11.1:

  healthz:
    Container ID:
    Image:         k8s.gcr.io/
    Image ID:
    Port:          8080/TCP
    Args:
      --cmd=nslookup kubernetes.default.svc.cluster.local 127.0.0.1 >/dev/null
      --url=/healthz-dnsmasq
      --cmd=nslookup kubernetes.default.svc.cluster.local 127.0.0.1:10053 >/dev/null
      --url=/healthz-kubedns
      --port=8080
      --quiet

I think #3595 didn't go far enough, so this adds the exechealthz def to 1.11 and 1.12.

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

restore exechealthz defs for back compat to 1.11 and 1.12

@ghost ghost assigned mboersma Aug 6, 2018
@ghost ghost added the in progress label Aug 6, 2018
@acs-bot acs-bot added the size/XS label Aug 6, 2018
@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #3620 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3620      +/-   ##
==========================================
+ Coverage    55.5%   55.51%   +<.01%     
==========================================
  Files         107      107              
  Lines       16194    16196       +2     
==========================================
+ Hits         8989     8991       +2     
  Misses       6432     6432              
  Partials      773      773

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Aug 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit cbb519c into Azure:master Aug 7, 2018
@ghost ghost removed the in progress label Aug 7, 2018
@mboersma mboersma deleted the exechealthz-backcompat branch August 7, 2018 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants