This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
refactor CSE to separate installs #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3642 +/- ##
==========================================
+ Coverage 55.65% 55.66% +0.01%
==========================================
Files 108 108
Lines 16026 16032 +6
==========================================
+ Hits 8919 8925 +6
Misses 6341 6341
Partials 766 766 |
CecileRobertMichon
force-pushed
the
refactor-CSE-vhd
branch
from
1c8e582
to
20c65df
Compare
| CRI_CONTAINERD_VERSION="1.1.0" | ||
| CONTAINERD_DOWNLOAD_URL="${CONTAINERD_DOWNLOAD_URL_BASE}cri-containerd-${CRI_CONTAINERD_VERSION}.linux-amd64.tar.gz" | ||
| CONTAINERD_TGZ_TMP=/tmp/containerd.tar.gz | ||
| retrycmd_get_tarball 60 5 "$CONTAINERD_TGZ_TMP" "$CONTAINERD_DOWNLOAD_URL" || exit $ERR_CONTAINERD_DOWNLOAD_TIMEOUT |
There was a problem hiding this comment.
added exit code here
|
/lgtm pending E2E |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
added 16 commits
August 13, 2018 16:51
CecileRobertMichon
force-pushed
the
refactor-CSE-vhd
branch
from
b1bdff3
to
bf408ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Separate installs from runtime configs and simplify the Linux custom script to help the vhd effort. Based on #3536
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: