Add Packer #3650
Add Packer #3650
Conversation
ghost
assigned 
packer.mk
Outdated
| @packer version && make az-login && make init-packer && (make build-packer | tee packer-output) | ||
|
|
||
| az-copy: | ||
| @make az-login && (azcopy --source "${OS_DISK_SAS}" --destination "${CLASSIC_BLOB}/${VHD_NAME}" --dest-sas "${CLASSIC_SAS_TOKEN}") |
There was a problem hiding this comment.
I think az login should be a make target dependency instead:
az-copy: az-login
azcopy --source "${OS_DISK_SAS}" --destination "${CLASSIC_BLOB}/${VHD_NAME}" --dest-sas "${CLASSIC_SAS_TOKEN}"Same for the generate-sas: target below.
There was a problem hiding this comment.
Good point, I'll fix it. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #3650 +/- ##
==========================================
+ Coverage 55.99% 56.03% +0.03%
==========================================
Files 108 108
Lines 16314 16314
==========================================
+ Hits 9135 9141 +6
+ Misses 6412 6404 -8
- Partials 767 769 +2 |
|
@mboersma I addressed your comments, please take a look when you can |
packer.mk
Outdated
| az login --service-principal -u ${CLIENT_ID} -p ${CLIENT_SECRET} --tenant ${TENANT_ID} | ||
|
|
||
| run-packer: az-login | ||
| @packer version && make init-packer && (make build-packer | tee packer-output) |
There was a problem hiding this comment.
When you invoke make from inside a Makefile, it should be referred to as $(MAKE) according to the GNU docs.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
|
What this PR does / why we need it: Add Packer for building custom vhd images https://www.packer.io/docs/builders/azure.html. Based on #3536
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: