diff --git a/parts/k8s/kuberneteswindowssetup.ps1 b/parts/k8s/kuberneteswindowssetup.ps1 index 27fb7c83d8..e6dc200292 100644 --- a/parts/k8s/kuberneteswindowssetup.ps1 +++ b/parts/k8s/kuberneteswindowssetup.ps1 @@ -406,7 +406,8 @@ try New-ExternalHnsNetwork -IsDualStackEnabled $global:IsDualStackEnabled Install-KubernetesServices ` - -KubeDir $global:KubeDir + -KubeDir $global:KubeDir ` + -ContainerRuntime $global:ContainerRuntime Get-LogCollectionScripts diff --git a/parts/k8s/windowskubeletfunc.ps1 b/parts/k8s/windowskubeletfunc.ps1 index a64f9bf7c6..8c41d1de83 100644 --- a/parts/k8s/windowskubeletfunc.ps1 +++ b/parts/k8s/windowskubeletfunc.ps1 @@ -315,10 +315,12 @@ New-NSSMService { $KubeletStartFile, [string] [Parameter(Mandatory = $true)] - $KubeProxyStartFile + $KubeProxyStartFile, + [Parameter(Mandatory = $false)][string] + $ContainerRuntime = "docker" ) - $kubeletDependOnServices = "docker" + $kubeletDependOnServices = $ContainerRuntime if ($global:EnableCsiProxy) { $kubeletDependOnServices += " csi-proxy" } @@ -373,7 +375,9 @@ function Install-KubernetesServices { param( [Parameter(Mandatory = $true)][string] - $KubeDir + $KubeDir, + [Parameter(Mandatory = $false)][string] + $ContainerRuntime = "docker" ) # TODO ksbrmnn fix callers to this function @@ -383,5 +387,6 @@ Install-KubernetesServices { New-NSSMService -KubeDir $KubeDir ` -KubeletStartFile $KubeletStartFile ` - -KubeProxyStartFile $KubeProxyStartFile + -KubeProxyStartFile $KubeProxyStartFile ` + -ContainerRuntime $ContainerRuntime } diff --git a/pkg/engine/templates_generated.go b/pkg/engine/templates_generated.go index bc662badd3..e26449a665 100644 --- a/pkg/engine/templates_generated.go +++ b/pkg/engine/templates_generated.go @@ -17522,7 +17522,8 @@ try New-ExternalHnsNetwork -IsDualStackEnabled $global:IsDualStackEnabled Install-KubernetesServices ` + "`" + ` - -KubeDir $global:KubeDir + -KubeDir $global:KubeDir ` + "`" + ` + -ContainerRuntime $global:ContainerRuntime Get-LogCollectionScripts @@ -19524,10 +19525,12 @@ New-NSSMService { $KubeletStartFile, [string] [Parameter(Mandatory = $true)] - $KubeProxyStartFile + $KubeProxyStartFile, + [Parameter(Mandatory = $false)][string] + $ContainerRuntime = "docker" ) - $kubeletDependOnServices = "docker" + $kubeletDependOnServices = $ContainerRuntime if ($global:EnableCsiProxy) { $kubeletDependOnServices += " csi-proxy" } @@ -19582,7 +19585,9 @@ function Install-KubernetesServices { param( [Parameter(Mandatory = $true)][string] - $KubeDir + $KubeDir, + [Parameter(Mandatory = $false)][string] + $ContainerRuntime = "docker" ) # TODO ksbrmnn fix callers to this function @@ -19592,7 +19597,8 @@ Install-KubernetesServices { New-NSSMService -KubeDir $KubeDir ` + "`" + ` -KubeletStartFile $KubeletStartFile ` + "`" + ` - -KubeProxyStartFile $KubeProxyStartFile + -KubeProxyStartFile $KubeProxyStartFile ` + "`" + ` + -ContainerRuntime $ContainerRuntime } `) diff --git a/vhd/packer/configure-windows-vhd.ps1 b/vhd/packer/configure-windows-vhd.ps1 index b91173f906..37f6bc79b6 100644 --- a/vhd/packer/configure-windows-vhd.ps1 +++ b/vhd/packer/configure-windows-vhd.ps1 @@ -331,10 +331,10 @@ switch ($env:ProvisioningPhase) { "2" { Write-Log "Performing actions for provisioning phase 2 for container runtime '$containerRuntime'" Set-WinRmServiceAutoStart - # TODO: make decision on if we want to install docker along with containerd (will need to update CSE too,) - Install-Docker if ($containerRuntime -eq 'containerd') { Install-ContainerD + } else { + Install-Docker } Update-Registry Get-ContainerImages -containerRuntime $containerRuntime -WindowsServerVersion $windowsServerVersion