Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: Add ACL rules for Windows #3833

Merged
merged 1 commit into from
Mar 16, 2021
Merged

feat: Add ACL rules for Windows #3833

merged 1 commit into from
Mar 16, 2021

Conversation

AbelHu
Copy link
Member

@AbelHu AbelHu commented Sep 16, 2020

Reason for Change:

feat: Add ACL rules for Windows

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #3833 (aa4aa2c) into master (f81f85f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3833   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files         141      141           
  Lines       21634    21634           
=======================================
  Hits        15590    15590           
  Misses       5093     5093           
  Partials      951      951           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 43.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4899b6f...aa4aa2c. Read the comment docs.

@jsturtevant
Copy link
Contributor

Could you give a some explanation on what these acl rules do and why they are needed? Maybe some documentation would be relevant?

@jsturtevant
Copy link
Contributor

/lgtm
/approve

@jsturtevant
Copy link
Contributor

/approve cancel

Wrong pr sorry. Still looking

@acs-bot acs-bot removed the approved label Sep 17, 2020
@stale
Copy link

stale bot commented Oct 17, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 17, 2020
@stale stale bot closed this Nov 16, 2020
@jsturtevant jsturtevant reopened this Feb 4, 2021
@stale stale bot removed the stale label Feb 4, 2021
@jsturtevant
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@jsturtevant
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsturtevant
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsturtevant
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsturtevant
Copy link
Contributor

There is a blocking issue for containerd in azurecni preventing pods from coming up. There is a fix in progress

 Warning  FailedCreatePodSandBox  28m                   kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "6f46dfcd7aa787bf251a5a142b3fdf647244c0cd4e7c798032e61e17dd28108f": Failed to create endpoint: Failed to set Policy: Type: EndpointPolicy, Data: {"Action":"Block","Direction":"Out","Priority":200,"Protocols":"6","RemoteAddresses":"168.63.129.16/32","RemotePorts":"80","RuleType":"Switch","Type":"ACL"}

@jsturtevant jsturtevant mentioned this pull request Mar 9, 2021
8 tasks
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset marosset merged commit 2f854cb into Azure:master Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants