-
Notifications
You must be signed in to change notification settings - Fork 522
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3833 +/- ##
=======================================
Coverage 72.06% 72.06%
=======================================
Files 141 141
Lines 21634 21634
=======================================
Hits 15590 15590
Misses 5093 5093
Partials 951 951
Continue to review full report at Codecov.
|
Could you give a some explanation on what these acl rules do and why they are needed? Maybe some documentation would be relevant? |
/lgtm |
/approve cancel Wrong pr sorry. Still looking |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/azp run |
Pull request contains merge conflicts. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There is a blocking issue for containerd in azurecni preventing pods from coming up. There is a fix in progress
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AbelHu, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
feat: Add ACL rules for Windows
Issue Fixed:
Requirements:
Notes: