Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: disable livenessProbe timeout enforcement #4085

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR addes the ExecProbeTimeout=false feature gate to 1.20 and later Kubernetes, to prevent livenessProbe timeout enforcement, which defaults to 1 second, from being introduced to an upgrade Kubernetes cluster suddenly.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #4085 (5877dc4) into master (6d292f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4085   +/-   ##
=======================================
  Coverage   73.18%   73.18%           
=======================================
  Files         135      135           
  Lines       20576    20577    +1     
=======================================
+ Hits        15058    15059    +1     
  Misses       4545     4545           
  Partials      973      973           
Impacted Files Coverage Δ
pkg/api/defaults-kubelet.go 96.59% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d292f1...5877dc4. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Dec 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit de89f5c into Azure:master Dec 3, 2020
@jackfrancis jackfrancis deleted the ExecProbeTimeout branch December 3, 2020 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants