Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.21.0-alpha.3 #4258

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

mboersma
Copy link
Member

Reason for Change:

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.21.md#changelog-since-v1210-alpha2

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #4258 (b6aa398) into master (6a8a5af) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4258   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         141      141           
  Lines       21676    21676           
=======================================
  Hits        15622    15622           
  Misses       5105     5105           
  Partials      949      949           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8a5af...b6aa398. Read the comment docs.

@jackfrancis
Copy link
Member

Can we remove the orchestrator version allow list from this test config file?

  • test/e2e/test_cluster_configs/availabilityset.json

Then I'll run the test matrix against that config to validate the 1.21 Windows + availability set + LB thing is fixed w/ alpha.3 (we have evidence it should be)

Thanks!

@jackfrancis
Copy link
Member

nevermind that reversion already landed!

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit c539187 into Azure:master Feb 11, 2021
@acs-bot
Copy link

acs-bot commented Feb 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the add-k8s-1.21.0-alpha.3 branch February 11, 2021 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants