Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: don't run unattended upgrade if using "no outbound" test feature #4297

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR ensures that when we're using the "block outbound internet access" test feature flag, we don't try to run unattended-upgrade as a blocking CSE operation (which will never finish due to default apt servers not being reachable).

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

Copy link
Collaborator

@Michael-Sinz Michael-Sinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, Michael-Sinz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #4297 (e4ec1f1) into master (77f6aa2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4297   +/-   ##
=======================================
  Coverage   72.03%   72.03%           
=======================================
  Files         141      141           
  Lines       21633    21633           
=======================================
  Hits        15584    15584           
  Misses       5099     5099           
  Partials      950      950           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 43.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f6aa2...e4ec1f1. Read the comment docs.

@jackfrancis jackfrancis merged commit a547b4a into Azure:master Feb 24, 2021
@jackfrancis jackfrancis deleted the no-outbound-unattended-upgrade branch February 24, 2021 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants