Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: update pause image to v3.4.1 #4333

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Mar 17, 2021

Reason for Change:

Updating pause image to v3.4.1 which supports Windows Server Ver 20H2

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Mar 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset
Copy link
Contributor Author

I did an install of datacetner-core-20h2-with-containers-smalldisk and checked the

(Get-ItemProperty "HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion").ReleaseId it reports as 2009

@jackfrancis
Copy link
Member

code lgtm, let's fix the merge conflict and run some tests

@marosset
Copy link
Contributor Author

/azp run-e2e

@azure-pipelines
Copy link

Command 'run-e2e' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@marosset
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #4333 (4daa563) into master (2f854cb) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4333   +/-   ##
=======================================
  Coverage   72.06%   72.07%           
=======================================
  Files         141      141           
  Lines       21634    21640    +6     
=======================================
+ Hits        15590    15596    +6     
  Misses       5093     5093           
  Partials      951      951           
Impacted Files Coverage Δ
pkg/api/common/helper.go 71.09% <ø> (ø)
pkg/api/k8s_versions.go 100.00% <ø> (ø)
pkg/engine/templates_generated.go 43.56% <ø> (ø)
pkg/api/addons.go 98.04% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f854cb...4daa563. Read the comment docs.

@marosset
Copy link
Contributor Author

/hold
Holding until new Windows VHD gets published and is set as the default VHD

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants