feat: deprecate Azure CNI networkmonitor daemonset

[jackfrancis]

Reason for Change:

This PR removes the installation of the additional "azure-cni-networkmonitor" daemonset, as this is no longer required with Azure CNI 1.20+ scenarios.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

• No
• Yes

If "Yes," did you notify that project's maintainers and provide attribution?

• No
• Yes

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:

[codecov]

Codecov Report

Merging #4363 (2a1b5d2) into master (3e59a51) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4363      +/-   ##
==========================================
- Coverage   72.08%   72.05%   -0.04%     
==========================================
  Files         141      141              
  Lines       21662    21629      -33     
==========================================
- Hits        15616    15585      -31     
+ Misses       5094     5093       -1     
+ Partials      952      951       -1     

Impacted Files	Coverage Δ
pkg/engine/artifacts.go	98.88% <ø> (-0.03%)	⬇️
pkg/engine/templates_generated.go	43.31% <ø> (-0.25%)	⬇️
pkg/api/addons.go	98.01% <100.00%> (-0.03%)	⬇️
pkg/api/k8s_versions.go	100.00% <100.00%> (ø)
pkg/api/vlabs/validate.go	81.83% <100.00%> (+0.05%)	⬆️
pkg/api/common/versions.go	96.37% <0.00%> (ø)
pkg/engine/template_generator.go	68.54% <0.00%> (+0.14%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e59a51...2a1b5d2. Read the comment docs.

[jadarsie]

/lgtm

[mboersma]

/lgtm!

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis,jadarsie,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ludydoo]

Hello! Does this mean that aks with kubernetes 1.20.2 should uninstall azure-cni-networkmonitor ?

[jackfrancis]

I believe @paulgmiller can answer your question @ludydoo. My understanding is that AKS is already working on delivering a networkmonitor-free Azure CNI solution.

[ludydoo]

Thanks @paulgmiller . I'm asking because I'm experiencing bugs with azure iptables when using Networkpolicies. Seems I have to restart the azure-npm pods. Wondering if there's a race condition between azure-cni-networkmonitor and azure-npm... Really not sure at this point

[paulgmiller]

Anything with all agents on azure cni >= 1.20 doesn't network monitor. It shouldn't in theory conflict with azure npm but if you fidn that it does we should make an issue of in the azure-container-networking repo.