Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: Force restart kubeproxy to avoid stucking #4375

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

AbelHu
Copy link
Member

@AbelHu AbelHu commented Apr 21, 2021

Reason for Change:

fix #4351

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:
We ran our test > 40 times and do not hit the issue with this change

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #4375 (1f841a9) into master (60828c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4375   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files         141      141           
  Lines       21631    21631           
=======================================
  Hits        15584    15584           
  Misses       5096     5096           
  Partials      951      951           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 43.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8a38f...1f841a9. Read the comment docs.

@@ -107,7 +107,6 @@ if ($global:CsiProxyEnabled) {
Write-Log "Starting kubelet service"
Start-Service kubelet

Write-Log "Starting kubeproxy service"
Start-Service kubeproxy
Write-Log "Do not start kubeproxy service since kubelet will restart kubeproxy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be a comment over start-service kubelet? It makes sense in context here with the diff. Later it might be a bit of an odd logging statement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I planned to log it in windowsnodereset.log so it will not surprise anyone why not restart kubeproxy when checking the logs. How do you think?

@jsturtevant
Copy link
Contributor

jsturtevant commented Apr 22, 2021

the failure in the aks-engine Windows provisioning scripts CI job was during deleting the storage account. The e2e tests passed.

Ran 43 of 65 Specs in 4016.718 seconds
SUCCESS! -- 43 Passed | 0 Failed | 0 Pending | 22 Skipped
PASS

Ginkgo ran 1 suite in 1h6m56.89560728s
Test Suite Passed

/lgtm
/approve

@acs-bot
Copy link

acs-bot commented Apr 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsturtevant jsturtevant merged commit 73d6981 into Azure:master Apr 22, 2021
@AbelHu AbelHu deleted the abelch/force-restart-kubeproxy branch April 22, 2021 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubelet in Windows node hangs in "Waiting for service 'Kubeproxy (Kubeproxy)' to stop..."
3 participants