Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: cluster.sh fixes for rotate-certs #4382

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

jadarsie
Copy link
Member

Reason for Change:

Pushing upstream a few rotate-certs e2e fixes we have in place in our own CI.

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #4382 (476b6c7) into master (47c439d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4382      +/-   ##
==========================================
- Coverage   72.07%   72.04%   -0.03%     
==========================================
  Files         141      141              
  Lines       21640    21631       -9     
==========================================
- Hits        15596    15584      -12     
- Misses       5093     5096       +3     
  Partials      951      951              
Impacted Files Coverage Δ
cmd/upgrade.go 35.92% <0.00%> (-0.54%) ⬇️
pkg/api/defaults.go 93.14% <0.00%> (-0.31%) ⬇️
pkg/engine/templates_generated.go 43.31% <0.00%> (-0.25%) ⬇️
pkg/api/addons.go 98.01% <0.00%> (-0.03%) ⬇️
pkg/engine/artifacts.go 98.88% <0.00%> (-0.03%) ⬇️
pkg/api/types.go 92.85% <0.00%> (ø)
pkg/api/vlabs/types.go 73.04% <0.00%> (ø)
pkg/api/k8s_versions.go 100.00% <0.00%> (ø)
pkg/api/common/versions.go 96.37% <0.00%> (ø)
pkg/api/converterfromapi.go 95.70% <0.00%> (+<0.01%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c439d...476b6c7. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acs-bot
Copy link

acs-bot commented Apr 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jadarsie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jadarsie jadarsie merged commit 8d56554 into Azure:master Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants