Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: treat failures in cleanup tasks for pr-windows-signed-scripts.yaml as warmings not errors #4384

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Apr 23, 2021

Signed-off-by: Mark Rossetti marosset@microsoft.com

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

…l as warmings not errors

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@jsturtevant
Copy link
Contributor

Thanks for fixing that!

/lgtm

@acs-bot
Copy link

acs-bot commented Apr 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #4384 (9e14b97) into master (60828c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4384   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files         141      141           
  Lines       21631    21631           
=======================================
  Hits        15584    15584           
  Misses       5096     5096           
  Partials      951      951           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/engine/templates_generated.go 43.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d36c2...9e14b97. Read the comment docs.

@marosset marosset merged commit 1e52c03 into Azure:master Apr 26, 2021
@marosset marosset deleted the windows-provisioing-ci-fixes branch April 26, 2021 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants