chore: update Go toolchain to v1.16.3 #4385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4385 +/- ##
=======================================
Coverage 72.04% 72.04%
=======================================
Files 141 141
Lines 21631 21631
=======================================
Hits 15584 15584
Misses 5096 5096
Partials 951 951
Continue to review full report at Codecov.
|
| @@ -79,7 +79,7 @@ checkDesiredVersion() { | |||
| elif type "wget" > /dev/null; then | |||
| TAG=$(wget -q -O - $release_url | awk '/\/tag\//' | grep -v no-underline | grep "<a href=\"/Azure/aks-engine/releases" | head -n 1 | cut -d '"' -f 2 | awk '{n=split($NF,a,"/");print a[n]}' | awk 'a !~ $0{print}; {a=$0}') | |||
| fi | |||
| if [ "x$TAG" == "x" ]; then | |||
There was a problem hiding this comment.
This release of docker-go-dev also bumped shellcheck and it had new two new complaints which I fixed. This one is SC2268, which was a workaround for ancient, non-POSIX-compliant shells that it suggests is just confusing today.
There was a problem hiding this comment.
Well I lived long enough to see shellcheck take one for the team in the interest of practicality.
| @@ -159,8 +159,6 @@ else | |||
| SKIP_AFTER_UPGRADE="${SKIP_AFTER_SCALE_DOWN}|${SKIP_AFTER_UPGRADE}" | |||
| elif [ "${SCALE_CLUSTER}" = "true" ]; then | |||
| SKIP_AFTER_UPGRADE="${SKIP_AFTER_SCALE_DOWN}" | |||
| else | |||
There was a problem hiding this comment.
This is SC2269: "This variable is assigned to itself, so the assignment does nothing."
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
See https://github.com/deis/docker-go-dev/releases/tag/v1.31.0
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
Requirements:
Notes:
This fixes two new warnings emitted by
shellcheck:https://www.shellcheck.net/wiki/SC2269 -- This variable is assigned to itself
https://www.shellcheck.net/wiki/SC2268 -- Avoid x-prefix in comparisons