Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: Add support for custom runc deb URL #4403

Merged
merged 1 commit into from
May 12, 2021

Conversation

cpuguy83
Copy link
Member

Reason for Change:

This helps enable testing new runc packages on aks-engine clusters.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

This helps enable testing new runc packages on aks-engine clusters.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #4403 (7bd80b7) into master (60828c7) will increase coverage by 0.10%.
The diff coverage is 96.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4403      +/-   ##
==========================================
+ Coverage   72.04%   72.14%   +0.10%     
==========================================
  Files         141      141              
  Lines       21631    21722      +91     
==========================================
+ Hits        15584    15672      +88     
- Misses       5096     5099       +3     
  Partials      951      951              
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/api/types.go 92.85% <ø> (ø)
pkg/api/vlabs/types.go 73.04% <ø> (ø)
pkg/api/vlabs/validate.go 81.83% <ø> (ø)
pkg/engine/templates_generated.go 43.31% <ø> (ø)
pkg/engine/template_generator.go 68.37% <50.00%> (-0.17%) ⬇️
pkg/api/addons.go 98.01% <100.00%> (ø)
pkg/api/converterfromapi.go 95.71% <100.00%> (+<0.01%) ⬆️
pkg/api/convertertoapi.go 94.04% <100.00%> (+0.01%) ⬆️
pkg/api/k8s_versions.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5945e7f...7bd80b7. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpuguy83, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 851c71a into Azure:master May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants