Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: May 2021 Windows patch update #4404

Merged
merged 3 commits into from
May 12, 2021

Conversation

jsturtevant
Copy link
Contributor

Reason for Change:

May WS patch updates

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

jackfrancis
jackfrancis previously approved these changes May 11, 2021
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #4404 (ea11630) into master (60828c7) will increase coverage by 0.07%.
The diff coverage is 84.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4404      +/-   ##
==========================================
+ Coverage   72.04%   72.11%   +0.07%     
==========================================
  Files         141      141              
  Lines       21631    21732     +101     
==========================================
+ Hits        15584    15672      +88     
- Misses       5096     5108      +12     
- Partials      951      952       +1     
Impacted Files Coverage Δ
cmd/rotate_certs.go 11.03% <0.00%> (ø)
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/api/vlabs/validate.go 81.83% <ø> (ø)
pkg/engine/templates_generated.go 43.31% <ø> (ø)
cmd/get_logs.go 49.57% <23.80%> (-1.79%) ⬇️
pkg/api/addons.go 98.01% <100.00%> (ø)
pkg/api/k8s_versions.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2cad6...ea11630. Read the comment docs.

@jsturtevant
Copy link
Contributor Author

Failure was

    azure-arm: 2021-05-11T20:12:24.6493529+00:00: Disabling automatic windows upates
    azure-arm: 2021-05-11T20:12:24.6962570+00:00: Downloading windows patch from http://download.windowsupdate.com/c/msdownload/update/software/secu/2021/05/windows10.0-kb5003171-x64_30162051d5376b7a19c4c25157347c522e804bbb.msu to C:\Users\packer\AppData\Local\Temp\windows10.0-kb5003171-x64_30162051d5376b7a19c4c25157347c522e804bbb.msu
    azure-arm: 2021-05-11T20:12:28.4681113+00:00: Starting install of windows10.0-kb5003171-x64_30162051d5376b7a19c4c25157347c522e804bbb.msu
    azure-arm: 2021-05-11T20:13:17.4064509+00:00: Error during install of windows10.0-kb5003171-x64_30162051d5376b7a19c4c25157347c522e804bbb.msu. ExitCode: -2145124329

I am not sure if this is transient. Wasn't able to find much info on that exit code. Going to try again and if it fails will look further.

@AbelHu
Copy link
Member

AbelHu commented May 12, 2021

@jsturtevant It seems like that 5b needs to install KB5003243. https://support.microsoft.com/en-us/topic/may-11-2021-kb5003171-os-build-17763-1935-3f03e74b-4759-4ca3-b9f1-4bc0d5ab5d27
Before installing this update

Prerequisite:

You must install the May 11, 2021 servicing stack update (SSU) (KB5003243) or later before installing the latest cumulative update (LCU). SSUs improve the reliability of the update process to mitigate potential issues while installing the LCU and applying Microsoft security fixes. For general information about SSUs, see Servicing stack updates and Servicing Stack Updates (SSU): Frequently Asked Questions.

If you are using Windows Update, the SSU will be offered to you automatically. To get the standa

@acs-bot
Copy link

acs-bot commented May 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, jackfrancis, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jsturtevant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsturtevant
Copy link
Contributor Author

Finally found this document that has a list of the error codes incase anyone runs into this in the future: https://missionimpossiblecode.io/post/logging-and-error-handling-best-practices-for-automating-windows-update-installs-msu-with-wusa.exe-and-for-logging-any-called-process

@jsturtevant jsturtevant merged commit 1fe4c07 into Azure:master May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants