Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: only validate MTU if Eth0MTU is present #4434

Merged
merged 1 commit into from
May 24, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR tweaks the E2E test implementation so that /sys/class/net/eth0/mtu is not validated unless the LinuxProfile.Eth0MTU property is present (e.g., kubenet).

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #4434 (ba0ead4) into master (60828c7) will increase coverage by 0.00%.
The diff coverage is 71.89%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #4434    +/-   ##
========================================
  Coverage   72.04%   72.05%            
========================================
  Files         141      141            
  Lines       21631    21764   +133     
========================================
+ Hits        15584    15681    +97     
- Misses       5096     5131    +35     
- Partials      951      952     +1     
Impacted Files Coverage Δ
cmd/rotate_certs.go 11.03% <0.00%> (ø)
cmd/upgrade.go 35.92% <0.00%> (ø)
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/api/types.go 92.85% <ø> (ø)
pkg/api/vlabs/types.go 73.04% <ø> (ø)
pkg/engine/templates_generated.go 43.31% <ø> (ø)
pkg/engine/template_generator.go 66.37% <11.53%> (-2.17%) ⬇️
cmd/get_logs.go 49.57% <30.43%> (-1.79%) ⬇️
pkg/api/addons.go 98.01% <100.00%> (ø)
pkg/api/converterfromapi.go 95.71% <100.00%> (+<0.01%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055cfaa...ba0ead4. Read the comment docs.

@acs-bot
Copy link

acs-bot commented May 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haofan-ms, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 278a8b3 into Azure:master May 24, 2021
@jackfrancis jackfrancis deleted the mtu-kubenet branch May 25, 2021 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants