Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: updates error msg in addpool cmd #4446

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Jun 8, 2021

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

Reason for Change:

This makes flag name in error message consistent with flag required by addpool cmd

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@welcome
Copy link

welcome bot commented Jun 8, 2021

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@mboersma
Copy link
Member

mboersma commented Jun 8, 2021

/azp pr-e2e

@azure-pipelines
Copy link

Command 'pr-e2e' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@mboersma
Copy link
Member

mboersma commented Jun 8, 2021

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #4446 (9b46500) into master (60828c7) will increase coverage by 0.00%.
The diff coverage is 72.43%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #4446    +/-   ##
========================================
  Coverage   72.04%   72.05%            
========================================
  Files         141      141            
  Lines       21631    21764   +133     
========================================
+ Hits        15584    15681    +97     
- Misses       5096     5131    +35     
- Partials      951      952     +1     
Impacted Files Coverage Δ
cmd/rotate_certs.go 11.03% <0.00%> (ø)
cmd/upgrade.go 35.92% <0.00%> (ø)
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/api/types.go 92.85% <ø> (ø)
pkg/api/vlabs/types.go 73.04% <ø> (ø)
pkg/engine/template_generator.go 66.37% <11.53%> (-2.17%) ⬇️
cmd/get_logs.go 49.57% <30.43%> (-1.79%) ⬇️
cmd/addpool.go 17.97% <100.00%> (ø)
pkg/api/addons.go 98.01% <100.00%> (ø)
pkg/api/converterfromapi.go 95.71% <100.00%> (+<0.01%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278a8b3...9b46500. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @nilekhc

@acs-bot
Copy link

acs-bot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, nilekhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 8c3ba39 into Azure:master Jun 10, 2021
@welcome
Copy link

welcome bot commented Jun 10, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@nilekhc nilekhc deleted the fix-addpool-error branch June 10, 2021 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants