Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: Update Azure CNI to 1.4.0 #4500

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

AbelHu
Copy link
Member

@AbelHu AbelHu commented Jun 25, 2021

Reason for Change:

chore: Update Azure CNI to 1.4.0

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@e6c160c). Click here to learn what that means.
The diff coverage is 38.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4500   +/-   ##
=========================================
  Coverage          ?   72.05%           
=========================================
  Files             ?      141           
  Lines             ?    21765           
  Branches          ?        0           
=========================================
  Hits              ?    15682           
  Misses            ?     5131           
  Partials          ?      952           
Impacted Files Coverage Δ
cmd/rotatecerts/arm.go 0.00% <0.00%> (ø)
cmd/rotate_certs.go 11.03% <11.03%> (ø)
cmd/scale.go 12.56% <12.37%> (ø)
cmd/addpool.go 17.97% <17.97%> (ø)
cmd/update.go 23.07% <23.07%> (ø)
cmd/upgrade.go 35.92% <25.00%> (ø)
cmd/get_logs.go 49.57% <49.57%> (ø)
cmd/get_skus.go 50.63% <50.63%> (ø)
cmd/root.go 56.28% <52.63%> (ø)
cmd/generate.go 50.41% <54.54%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c160c...904b0ce. Read the comment docs.

@AbelHu
Copy link
Member Author

AbelHu commented Jun 25, 2021

@jsturtevant
Copy link
Contributor

I think the 1.22 job is know flaky @jackfrancis? I've restarted it.

@jsturtevant
Copy link
Contributor

/lgtm

@jackfrancis
Copy link
Member

@jsturtevant Not the version that we have support for, let's wait to see what the re-run yields.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, jackfrancis, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jsturtevant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 0563f3d into Azure:master Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants