Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: use go 1.16 everywhere #4528

Merged
merged 1 commit into from
Jun 28, 2021
Merged

ci: use go 1.16 everywhere #4528

merged 1 commit into from
Jun 28, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR rationalizes the various go CI to use 1.16 everywhere.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@@ -1 +0,0 @@
1.14.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find any reason to keep this hidden file around

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it was to support goenv? I used to use that, and I'm the only commiter on that file. 👍🏻 to deleting it.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@7ca2a31). Click here to learn what that means.
The diff coverage is 38.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4528   +/-   ##
=========================================
  Coverage          ?   72.05%           
=========================================
  Files             ?      141           
  Lines             ?    21765           
  Branches          ?        0           
=========================================
  Hits              ?    15682           
  Misses            ?     5131           
  Partials          ?      952           
Impacted Files Coverage Δ
cmd/rotatecerts/arm.go 0.00% <0.00%> (ø)
cmd/rotate_certs.go 11.03% <11.03%> (ø)
cmd/scale.go 12.56% <12.37%> (ø)
cmd/addpool.go 17.97% <17.97%> (ø)
cmd/update.go 23.07% <23.07%> (ø)
cmd/upgrade.go 35.92% <25.00%> (ø)
cmd/get_logs.go 49.57% <49.57%> (ø)
cmd/get_skus.go 50.63% <50.63%> (ø)
cmd/root.go 56.28% <52.63%> (ø)
cmd/generate.go 50.41% <54.54%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca2a31...68b3b7e. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit bf8b198 into Azure:master Jun 28, 2021
@jackfrancis jackfrancis deleted the go-1.16 branch June 28, 2021 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants