Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: remove manually curated azure const UT #4535

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR removes manually maintained UT that test the literal response from various azure const convenience funcs.

This will allow us to automate the continual maintenance of VM SKUs, locations, etc.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@bf8b198). Click here to learn what that means.
The diff coverage is 38.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4535   +/-   ##
=========================================
  Coverage          ?   71.83%           
=========================================
  Files             ?      141           
  Lines             ?    21765           
  Branches          ?        0           
=========================================
  Hits              ?    15635           
  Misses            ?     5179           
  Partials          ?      951           
Impacted Files Coverage Δ
cmd/rotatecerts/arm.go 0.00% <0.00%> (ø)
cmd/rotate_certs.go 11.03% <11.03%> (ø)
cmd/scale.go 12.56% <12.37%> (ø)
cmd/addpool.go 17.97% <17.97%> (ø)
cmd/update.go 23.07% <23.07%> (ø)
cmd/upgrade.go 35.92% <25.00%> (ø)
cmd/get_logs.go 49.57% <49.57%> (ø)
cmd/root.go 56.28% <52.63%> (ø)
cmd/generate.go 50.41% <54.54%> (ø)
cmd/deploy.go 60.79% <61.68%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8b198...b2ab861. Read the comment docs.

@jackfrancis jackfrancis merged commit 1a8c2a2 into Azure:master Jun 28, 2021
@jackfrancis jackfrancis deleted the ut-azure-consts branch June 28, 2021 23:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants